trace: Remove unused workqueue tracer
This tracer was temporarily removed in 6416669 (workqueue:
temporarily remove workqueue tracing, 2010-06-29) but never reinstated after concurrency managed workqueues were completed. For almost two years it hasn't been compilable so it seems nobody is using it. Delete it.
---
I noticed this while poking through the tracer code. This patch is meant to incite discussion.
Can this tracer be salvaged? In it's simplest form I suppose we can trace the number of queued, active, running, and completed work items.
kernel/trace/Makefile | 1 - kernel/trace/trace_workqueue.c | 300 ---------------------------------------- 2 files changed, 301 deletions(-) delete mode 100644 kernel/trace/trace_workqueue.c
kernel/trace/Makefile +0 -1
@@ -41,7 +41,6 @@ obj-$(CONFIG_STACK_TRACER) += trace_stack.o obj-$(CONFIG_MMIOTRACE) += trace_mmiotrace.o obj-$(CONFIG_FUNCTION_GRAPH_TRACER) += trace_functions_graph.o obj-$(CONFIG_TRACE_BRANCH_PROFILING) += trace_branch.o -obj-$(CONFIG_WORKQUEUE_TRACER) += trace_workqueue.o obj-$(CONFIG_BLK_DEV_IO_TRACE) += blktrace.o ifeq ($(CONFIG_BLOCK),y) obj-$(CONFIG_EVENT_TRACING) += blktrace.o
kernel/trace/trace_workqueue.c deleted +0 -300
300 lines not on this page · raw message
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Quoted 9 lines · Stephen Boyd
This tracer was temporarily removed in 6416669 (workqueue:
temporarily remove workqueue tracing, 2010-06-29) but never reinstated after concurrency managed workqueues were completed. For almost two years it hasn't been compilable so it seems nobody is using it. Delete it.Cc Frederic Weisbecker <[email protected]>Cc Tejun Heo <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Yeah, I feel somewhat guilty about this. The plan was to make it work again once cmwq is stable but I never got around to it. That said, if nobody is using it, shedding code is always nice. If nobody objects, I'll push this patch through wq/for-3.5. We can revive it later if necessary.
Thank you.
Signature · 1 line
tejun
Frederic Weisbecker
Acked-by2012/4/9 Tejun Heo <[email protected]>:
Quoted 11 lines · Stephen Boyd
Quoted 9 lines
This tracer was temporarily removed in 6416669 (workqueue:
temporarily remove workqueue tracing, 2010-06-29) but never reinstated after concurrency managed workqueues were completed. For almost two years it hasn't been compilable so it seems nobody is using it. Delete it.Cc Frederic Weisbecker <[email protected]>Cc Tejun Heo <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 5 lines
Yeah, I feel somewhat guilty about this. The plan was to make it work again once cmwq is stable but I never got around to it. That said, if nobody is using it, shedding code is always nice. If nobody objects, I'll push this patch through wq/for-3.5. We can revive it later if necessary.
No problem for me.
Tejun Heo
AppliedQuoted 18 lines · Frederic Weisbecker
2012/4/9 Tejun Heo <[email protected]>:
Quoted 11 lines · Stephen Boyd
Quoted 9 lines
This tracer was temporarily removed in 6416669 (workqueue:
temporarily remove workqueue tracing, 2010-06-29) but never reinstated after concurrency managed workqueues were completed. For almost two years it hasn't been compilable so it seems nobody is using it. Delete it.Cc Frederic Weisbecker <[email protected]>Cc Tejun Heo <[email protected]>Signed-off-by Stephen Boyd <[email protected]>Quoted 5 lines
Yeah, I feel somewhat guilty about this. The plan was to make it work again once cmwq is stable but I never got around to it. That said, if nobody is using it, shedding code is always nice. If nobody objects, I'll push this patch through wq/for-3.5. We can revive it later if necessary.
Quoted 3 lines
No problem for me.
Applied to wq/for-3.5. Thanks.
Signature · 1 line
tejun