Skip to contentSkip to conversation

regulator: 88pm8607: Fix writting value to vol_reg in pm8607_set_voltage_sel

PATCH Applied Axel Lin 2 participants 2 messages Apr 19, 2012 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: 88pm8607: Fix writting value to vol_reg in pm8607_set_voltage_sel

commit 4ca1e1d "regulator: Convert 88pm8607 to set_voltage_sel" accidentally changed the value writing to vol_reg.
What we want is to write val instead of selector to vol_reg.

Signed-off-by Axel Lin <[email protected]>

---
This only impact is setting LDO13, for other LDOs/BUCKs the shift is 0.

 drivers/regulator/88pm8607.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/88pm8607.c +1 -1
index d04fbe9..06d9c4b 100644
@@ -232,7 +232,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)
 	val = (uint8_t)(selector << info->vol_shift);
 	mask = (rdev->desc->n_voltages - 1)  << info->vol_shift;
 
-	ret = pm860x_set_bits(info->i2c, info->vol_reg, mask, selector);
+	ret = pm860x_set_bits(info->i2c, info->vol_reg, mask, val);
 	if (ret)
 		return ret;
 	switch (info->desc.id) {
Signature · 1 line
1.7.5.4
Applied
#1 lore raw
Quoted 3 lines · Axel Lin

commit 4ca1e1d "regulator: Convert 88pm8607 to set_voltage_sel" accidentally changed the value writing to vol_reg.
What we want is to write val instead of selector to vol_reg.

Applied, thanks.