utils.bbclass: Testing via env in create_wrapper is a nice idea but breaks things

PATCH Richard Purdie 1 participant 1 message Apr 19, 2012

Share & tools

Richard Purdie

author

2012-04-19 22:11 UTC #0 lore raw

For example, pseudo-native wants to set LD_LIBRBARY_PATH but setting this into the environment here causes the existing pseudo (running during do_install) to poke into paths in /opt and this breaks builds.

The simplest fix is simply not to do this. Comments tweaks to match the code.

Signed-off-by Richard Purdie <[email protected]>

---

meta/classes/utils.bbclass +1 -3

index 3b59463..fde8f44 100644
@@ -282,7 +282,6 @@ create_cmdline_wrapper () {
    cmd=$1
    shift
 
-   # run echo via env to test syntactic validity of the variable arguments
    echo "Generating wrapper script for $cmd"
 
    mv $cmd $cmd.real

@@ -306,8 +305,7 @@ create_wrapper () {
    cmd=$1
    shift
 
-   # run echo via env to test syntactic validity of the variable arguments
-   env $@ echo "Generating wrapper script for $cmd"
+   echo "Generating wrapper script for $cmd"
 
    mv $cmd $cmd.real
    cmdname=`basename $cmd`.real