Skip to contentSkip to conversation

m68k: fix compiler warning by properly inlining flat_set_persistent()

RFC/PATCH Ezequiel Garcia 1 participant 1 message Apr 23, 2012 m68k architecture

lore
Share & tools
lore
#0 lore raw

---
To define or to inline that is the question:
The current definition of flat_set_persistent produces a compiler warning; arch/sh/ does it in a different way defining it to a macro that uses persistent var. IMHO, an inline is easier to read.

---
 arch/m68k/include/asm/flat.h |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
arch/m68k/include/asm/flat.h +6 -1
index a0e2907..f9454b8 100644
@@ -11,6 +11,11 @@
 #define	flat_get_addr_from_rp(rp, relval, flags, p)	get_unaligned(rp)
 #define	flat_put_addr_at_rp(rp, val, relval)	put_unaligned(val,rp)
 #define	flat_get_relocate_addr(rel)		(rel)
-#define	flat_set_persistent(relval, p)		0
+
+static inline int flat_set_persistent(unsigned long relval,
+				      unsigned long *persistent)
+{
+	return 0;
+}
 
 #endif /* __M68KNOMMU_FLAT_H__ */
Signature · 1 line
1.7.3.4