drm/i915: disable sdvo hotplug on i945g/gm
Subsystems (2)
PATCH 1/1 drm/i915: disable sdvo hotplug on i945g/gm
Chris Wilson dug out a hw erratum saying that there's noise on the interrupt line on i945G chips. We also have a bug report from a i945GM chip with an sdvo hotplug interrupt storm (and no apparent cause).
Play it safe and disable sdvo hotplug on all i945 variants.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=38442
--- drivers/gpu/drm/i915/intel_sdvo.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/intel_sdvo.c +6 -0
@@ -1232,8 +1232,14 @@ static bool intel_sdvo_get_capabilities(struct intel_sdvo *intel_sdvo, struct instatic int intel_sdvo_supports_hotplug (struct intel_sdvo *intel_sdvo) { +struct drm_device *dev = intel_sdvo->base.base.dev;u8 response[2 ]; +/* HW Erratum: SDVO Hotplug is broken on all i945G chips, there's noise +* on the line. */ +if (IS_I945G (dev) ||IS_I945GM (dev)) +return false; +return intel_sdvo_get_value (intel_sdvo,SDVO_CMD_GET_HOT_PLUG_SUPPORT , &response,2 ) && response[0 ]; }
Signature · 6 lines
1.7.10 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Daniel Vetter
Chris Wilson dug out a hw erratum saying that there's noise on the interrupt line on i945G chips. We also have a bug report from a i945GM chip with an sdvo hotplug interrupt storm (and no apparent cause).
Play it safe and disable sdvo hotplug on all i945 variants.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=38442
Reported-and-tested-by Dominik Köppl <[email protected]>Cc Chris Wilson <[email protected]>Signed-off-by Daniel Vetter <[email protected]>
I've just realized that this is a regression that has been introduced in 3.1, when we've enabled sdvo hotplug support with
commit cc68c81aed7d892deaf12d720d5455208e94cd0a
Author: Simon Farnsworth <[email protected]> Date: Wed Sep 21 17:13:30 2011 +0100
drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI
-Daniel
Quoted 26 lines
--- drivers/gpu/drm/i915/intel_sdvo.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/i915/intel_sdvo.c +6
-0@@ -1232,8 +1232,14 @@ static bool intel_sdvo_get_capabilities(struct intel_sdvo *intel_sdvo, struct instatic int intel_sdvo_supports_hotplug (struct intel_sdvo *intel_sdvo) { +struct drm_device *dev = intel_sdvo->base.base.dev;u8 response[2 ]; +/* HW Erratum: SDVO Hotplug is broken on all i945G chips, there's noise +* on the line. */ +if (IS_I945G (dev) ||IS_I945GM (dev)) +return false; +return intel_sdvo_get_value (intel_sdvo,SDVO_CMD_GET_HOT_PLUG_SUPPORT , &response,2 ) && response[0 ]; }Signature · 1 line
1.7.10
Signature · 3 lines
Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48
Quoted 15 lines · Daniel Vetter
Quoted 10 lines · Daniel Vetter
Chris Wilson dug out a hw erratum saying that there's noise on the interrupt line on i945G chips. We also have a bug report from a i945GM chip with an sdvo hotplug interrupt storm (and no apparent cause).
Play it safe and disable sdvo hotplug on all i945 variants.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=38442
Reported-and-tested-by Dominik Köppl <[email protected]>Cc Chris Wilson <[email protected]>Signed-off-by Daniel Vetter <[email protected]>I've just realized that this is a regression that has been introduced in 3.1, when we've enabled sdvo hotplug support with
Quoted 7 lines
commit
cc68c81aed7d892deaf12d720d5455208e94cd0aAuthor: Simon Farnsworth <[email protected]> Date: Wed Sep 21 17:13:30 2011 +0100drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI
I've merged this patch to -fixes with Chris' irc r-b added. -Daniel
Signature · 3 lines
Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48