Skip to contentSkip to conversation

frv: delete incorrect task prototypes causing compile fail

PATCH New Paul Gortmaker 1 participant 1 message May 11, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 frv: delete incorrect task prototypes causing compile fail

Commit 41101809a865dd0be1b56eff46c83fad321870b2

"fork: Provide weak arch_release_[task_struct|thread_info] functions"

highlights a problem in the frv arch, where it has needles prototypes for alloc_task_struct_node and free_task_struct. This now shows up as:

kernel/fork.c:120:66: error: static declaration of 'alloc_task_struct_node' follows non-static declaration kernel/fork.c:127:51: error: static declaration of 'free_task_struct' follows non-static declaration

since 4110180 turned them into real functions. Since the arch/frv does does not define define __HAVE_ARCH_TASK_STRUCT_ALLOCATOR (i.e. it just uses the generic ones) it shouldn't list these at all.

Cc David Howells <[email protected]>
Cc Thomas Gleixner <[email protected]>
arch/frv/include/asm/processor.h +0 -4
index 81c2e27..9b1a92b 100644
@@ -135,10 +135,6 @@ unsigned long get_wchan(struct task_struct *p);
 #define	KSTK_EIP(tsk)	((tsk)->thread.frame0->pc)
 #define	KSTK_ESP(tsk)	((tsk)->thread.frame0->sp)
 
-/* Allocation and freeing of basic task resources. */
-extern struct task_struct *alloc_task_struct_node(int node);
-extern void free_task_struct(struct task_struct *p);
-
 #define cpu_relax()    barrier()
 
 /* data cache prefetch */
Signature · 1 line
1.7.9.1