Skip to contentSkip to conversation

tile: set KBUILD_DEFCONFIG to point at a real config file

PATCH In review Paul Gortmaker 2 participants 6 messages May 18, 2012 – May 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tile: set KBUILD_DEFCONFIG to point at a real config file

To fix this:

~/git/linux-head$ make defconfig
*** Default configuration is based on 'tile_defconfig'
***
*** Can't find default configuration "arch/tile/configs/tile_defconfig"!
***
make[1]: *** [defconfig] Error 1
make: *** [defconfig] Error 2

There is no need to use $ARCH in the tile/Makefile, since if we are in there, we know ARCH must be tile. Use the GX as the defconfig, as that is what is used in linux-next.

arch/tile/Makefile +1 -1
index 5015144..89f2310 100644
@@ -34,7 +34,7 @@ LIBGCC_PATH     := \
   $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
 
 # Provide the path to use for "make defconfig".
-KBUILD_DEFCONFIG := $(ARCH)_defconfig
+KBUILD_DEFCONFIG := tilegx_defconfig
 
 # Used as a file extension when useful, e.g. head_$(BITS).o
 # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
Signature · 1 line
1.7.9.1
#1 lore raw
Quoted 10 lines · Paul Gortmaker

To fix this:

~/git/linux-head$ make defconfig
*** Default configuration is based on 'tile_defconfig'
***
*** Can't find default configuration "arch/tile/configs/tile_defconfig"!
***
make[1]: *** [defconfig] Error 1
make: *** [defconfig] Error 2

Quoted 3 lines

There is no need to use $ARCH in the tile/Makefile, since if we are in there, we know ARCH must be tile. Use the GX as the defconfig, as that is what is used in linux-next.

No, the odd thing about arch/tile is that you must build it either as ARCH=tilepro or ARCH=tilegx. There is no ARCH=tile. So the $ARCH piece is actually correct.

Quoted 16 lines
arch/tile/Makefile +1 -1
index 5015144..89f2310 100644
@@ -34,7 +34,7 @@ LIBGCC_PATH     := \
   $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
 
 # Provide the path to use for "make defconfig".
-KBUILD_DEFCONFIG := $(ARCH)_defconfig
+KBUILD_DEFCONFIG := tilegx_defconfig
 
 # Used as a file extension when useful, e.g. head_$(BITS).o
 # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
Signature · 2 lines
Chris Metcalf, Tilera Corp.
http://www.tilera.com
#2 lore raw
Quoted 11 lines · [Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file] On…
Quoted 10 lines · Paul Gortmaker

To fix this:

~/git/linux-head$ make defconfig
*** Default configuration is based on 'tile_defconfig'
***
*** Can't find default configuration "arch/tile/configs/tile_defconfig"!
***
make[1]: *** [defconfig] Error 1
make: *** [defconfig] Error 2

Quoted 7 lines
Quoted 3 lines

There is no need to use $ARCH in the tile/Makefile, since if we are in there, we know ARCH must be tile. Use the GX as the defconfig, as that is what is used in linux-next.

No, the odd thing about arch/tile is that you must build it either as ARCH=tilepro or ARCH=tilegx. There is no ARCH=tile. So the $ARCH piece is actually correct.

That is interesting, since this is what I've been doing on any of my tile builds right from the beginning.

PATH=/home/paul/tc/tilegx-x86_64/bin:$PATH
export CROSS_COMPILE=tilegx-unknown-linux-gnu-
export ARCH=tile

...and it works. Aside from the defconfig thing I just reported. It is the same boilerplate type of env. settings I use for arm, mips and whatever other random thing I'm building. I'm pretty sure I'm not the only one who would make this assumption. Actually I *know* I am not the only one. Here is a snippet from linux-next build:

/scratch/kisskb/prod/kisskb/kisskb3/backend/makewrap.py ARCH=tile O=/scratch/kisskb/prod/kisskb/kisskb3/backend/build/linux-next_tilegx_defconfig_tilegx CROSS_COMPILE=/opt/cross/gcc-4.6.2-nolibc/tilegx-linux/bin/tilegx-linux- tilegx_defconfig

So maybe some validation on the ARCH value is in order if you really don't want people doing this?

Paul.
--

Quoted 22 lines
Quoted 17 lines
arch/tile/Makefile +1 -1
index 5015144..89f2310 100644
@@ -34,7 +34,7 @@ LIBGCC_PATH     := \
   $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
 
 # Provide the path to use for "make defconfig".
-KBUILD_DEFCONFIG := $(ARCH)_defconfig
+KBUILD_DEFCONFIG := tilegx_defconfig
 
 # Used as a file extension when useful, e.g. head_$(BITS).o
 # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
Signature · 2 lines
Chris Metcalf, Tilera Corp.
http://www.tilera.com
#3 lore raw
Quoted 32 lines · Paul Gortmaker
Quoted 11 lines · [Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file] On…
Quoted 10 lines · Paul Gortmaker

To fix this:

~/git/linux-head$ make defconfig
*** Default configuration is based on 'tile_defconfig'
***
*** Can't find default configuration "arch/tile/configs/tile_defconfig"!
***
make[1]: *** [defconfig] Error 1
make: *** [defconfig] Error 2

Quoted 6 lines
Quoted 3 lines

There is no need to use $ARCH in the tile/Makefile, since if we are in there, we know ARCH must be tile. Use the GX as the defconfig, as that is what is used in linux-next.

No, the odd thing about arch/tile is that you must build it either as ARCH=tilepro or ARCH=tilegx. There is no ARCH=tile. So the $ARCH piece is actually correct.

That is interesting, since this is what I've been doing on any of my tile builds right from the beginning.

PATH=/home/paul/tc/tilegx-x86_64/bin:$PATH
export CROSS_COMPILE=tilegx-unknown-linux-gnu-
export ARCH=tile

...and it works. Aside from the defconfig thing I just reported. It is the same boilerplate type of env. settings I use for arm, mips and whatever other random thing I'm building. I'm pretty sure I'm not the only one who would make this assumption. Actually I *know* I am not the only one. Here is a snippet from linux-next build:

Quoted 7 lines

/scratch/kisskb/prod/kisskb/kisskb3/backend/makewrap.py ARCH=tile O=/scratch/kisskb/prod/kisskb/kisskb3/backend/build/linux-next_tilegx_defconfig_tilegx CROSS_COMPILE=/opt/cross/gcc-4.6.2-nolibc/tilegx-linux/bin/tilegx-linux- tilegx_defconfig

So maybe some validation on the ARCH value is in order if you really don't want people doing this?

Yes. I think what I will do is "promote" ARCH=tile to ARCH=tilegx in arch/tile/Makefile as the "default" Tilera architecture. Thanks for the suggestion - I've been too close to this issue to actually notice it :-)

Signature · 2 lines
Chris Metcalf, Tilera Corp.
http://www.tilera.com
#4 lore raw
Quoted 1 line · [Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file] On…

On 5/18/2012 11:18 PM, Paul Gortmaker wrote:

[...]

Quoted 7 lines
Quoted 3 lines

So maybe some validation on the ARCH value is in order if you really don't want people doing this?

Yes. I think what I will do is "promote" ARCH=tile to ARCH=tilegx in arch/tile/Makefile as the "default" Tilera architecture. Thanks for the suggestion - I've been too close to this issue to actually notice it :-)

No problem, I figured that was the case -- that setting ARCH=tile never crossed your mind since you already knew what was expected by your own Makefile. :)

Paul.

Quoted 5 lines
Signature · 3 lines
-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com
#5 lore raw

PATCH 1/1 tile: default to tilegx_defconfig for ARCH=tile

In reply to Paul Gortmaker

There is no "ARCH=tile" (just like there is no "ARCH=x86") so we need to pick a default configuration, either tilepro or tilegx, when users specify ARCH=tile. We'll use tilegx, since that's our current chip.

---
 arch/tile/Makefile |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
arch/tile/Makefile +6 -1
index 5015144..55640cf 100644
@@ -34,7 +34,12 @@ LIBGCC_PATH     := \
   $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
 
 # Provide the path to use for "make defconfig".
-KBUILD_DEFCONFIG := $(ARCH)_defconfig
+# We default to the newer TILE-Gx architecture if only "tile" is given.
+ifeq ($(ARCH),tile)
+        KBUILD_DEFCONFIG := tilegx_defconfig
+else
+        KBUILD_DEFCONFIG := $(ARCH)_defconfig
+endif
 
 # Used as a file extension when useful, e.g. head_$(BITS).o
 # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
Signature · 1 line
1.6.5.2