Skip to contentSkip to conversation

driver core patches for 3.5-rc1 - try 2

PATCH Joe Perches 1 participant 1 message May 22, 2012

lore
Share & tools
lore
#0 lore raw

(resending cc'ing lkml)
(Also, apologies about no in-reply-to, lkml.org is down)

While there are several things I like about the printk modifications, (binary header, delta time, slightly better partial message deinterleaving, global msg_id, kmsg is ok too), I am concerned about the utility and expectations for the new [v]printk_emit functions.

I think it is not really ready to be merged at this time.

The commit sequencing was unclean.

The original commit originally required KERN_CONT and it was modified by another commit to return to the current behavior.

What really are the expectations and true use-cases for [v]printk_emit?

How is it really better that what is available now?

Perhaps it would be better to respin all the printk modifications without adding [v]printk_emit and have the [v]printk_emit bits debated a bit more.