remove repeat implementation of page_referenced

PATCH Wanpeng Li 2 participants 2 messages May 25, 2012 MM rmap

Share & tools

Wanpeng Li

author

2012-05-25 12:37 UTC #0 lore raw

page_referenced function just called from mm/vmscan.c to handle paging out.It is realized in mm/rmap.c and has an interface exported in rmap.h.

Signed-off-by Wanpeng Li <[email protected]>

---
 include/linux/rmap.h |    8 --------
 1 file changed, 8 deletions(-)

include/linux/rmap.h +0 -8

index fd07c45..ee0c005 100644
@@ -234,14 +234,6 @@ int rmap_walk(struct page *page, int (*rmap_one)(struct page *,
 #define anon_vma_prepare(vma)	(0)
 #define anon_vma_link(vma)	do {} while (0)
 
-static inline int page_referenced(struct page *page, int is_locked,
-				  struct mem_cgroup *memcg,
-				  unsigned long *vm_flags)
-{
-	*vm_flags = 0;
-	return 0;
-}
-
 #define try_to_unmap(page, refs) SWAP_FAIL
 
 static inline int page_mkclean(struct page *page)

Signature · 1 line

1.7.9.5

Peter Zijlstra

2012-05-25 12:47 UTC #1 lore raw

Quoted 4 lines · Wanpeng Li

From: Wanpeng Li <[email protected]>
page_referenced function just called from mm/vmscan.c to handle paging out.It is realized in mm/rmap.c and has an interface exported in rmap.h.

I think you'll find you've broken CONFIG_MMU=n builds with this.