Skip to contentSkip to conversation

build failure in mm/nommu.c

PATCH Mark Salter 2 participants 2 messages Jun 4, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Commit eb36c587: new helper: vm_mmap_pgoff()

is causing a build failure:

.../linux/mm/nommu.c: In function 'sys_mmap_pgoff':
.../linux/mm/nommu.c:1489:2: error: 'ret' undeclared (first use in this function) .../linux/mm/nommu.c:1489:2: note: each undeclared identifier is reported only once for each function it appears in

It looks like it just needs:

mm/nommu.c +1 -1
index c4acfbc..d4b0c10 100644
@@ -1486,7 +1486,7 @@ SYSCALL_DEFINE6(mmap_pgoff, unsigned long, addr, unsigned long, len,
 
 	flags &= ~(MAP_EXECUTABLE | MAP_DENYWRITE);
 
-	ret = vm_mmap_pgoff(file, addr, len, prot, flags, pgoff);
+	retval = vm_mmap_pgoff(file, addr, len, prot, flags, pgoff);
 
 	if (file)
 		fput(file);
#1 lore raw
Quoted 8 lines · Mark Salter

Commit eb36c587: new helper: vm_mmap_pgoff()

is causing a build failure:

.../linux/mm/nommu.c: In function 'sys_mmap_pgoff':
.../linux/mm/nommu.c:1489:2: error: 'ret' undeclared (first use in this function) .../linux/mm/nommu.c:1489:2: note: each undeclared identifier is reported only once for each function it appears in

Try pulling from Linus again, this is fixed by ad1ed2937eaa ("nommu: fix compilation of nommu.c") in his tree.