ALSA: hda - add power states information in proc
PATCH v2 1/1 ALSA: hda - add power states information in proc
add more power states information:
- reset status
- clock stop ok
- power states error
Output like:
Power: setting=D0, actual=D0, Error, Clock-stop-OK, Setting-reset
Signed-off-by Wang Xingchao <[email protected]>
--- sound/pci/hda/hda_codec.h | 3 +++ sound/pci/hda/hda_proc.c | 9 ++++++++- 2 files changed, 11 insertions(+), 1 deletion(-)
sound/pci/hda/hda_codec.h +3 -0
@@ -323,6 +323,9 @@ enum {#define AC_PWRST_D1 0x01#define AC_PWRST_D2 0x02#define AC_PWRST_D3 0x03 +#define AC_PWRST_ERROR (1<<8) +#define AC_PWRST_CLK_STOP_OK (1<<9) +#define AC_PWRST_SETTING_RESET (1<<10)/* Processing capabilies */ #define AC_PCAP_BENIGN (1<<0)
sound/pci/hda/hda_proc.c +8 -1
@@ -455,10 +455,17 @@ static void print_power_state(struct snd_info_buffer *buffer,snd_iprintf (buffer," Power states: %s\n" ,bits_names (sup, names,ARRAY_SIZE (names))); -snd_iprintf (buffer," Power: setting=%s, actual=%s\n" , +snd_iprintf (buffer," Power: setting=%s, actual=%s" ,get_pwr_state (pwr &AC_PWRST_SETTING ),get_pwr_state ((pwr &AC_PWRST_ACTUAL ) >>AC_PWRST_ACTUAL_SHIFT )); +if (pwr &AC_PWRST_ERROR ) +snd_iprintf (buffer," , Error" ); +if (pwr &AC_PWRST_CLK_STOP_OK ) +snd_iprintf (buffer," , Clock-stop-OK" ); +if (pwr &AC_PWRST_SETTING_RESET ) +snd_iprintf (buffer," , Setting-reset" ); +snd_iprintf (buffer,"\n" ); } static void print_unsol_cap(struct snd_info_buffer *buffer,
Signature · 1 line
1.7.9.5
At Wed, 6 Jun 2012 13:49:44 +0800,
Quoted 34 lines · Wang Xingchao
add more power states information:
- reset status
- clock stop ok
- power states errorOutput like:
Power: setting=D0, actual=D0, Error, Clock-stop-OK, Setting-resetSigned-off-by Wang Xingchao <[email protected]>--- sound/pci/hda/hda_codec.h | 3 +++ sound/pci/hda/hda_proc.c | 9 ++++++++- 2 files changed, 11 insertions(+), 1 deletion(-)sound/pci/hda/hda_codec.h +3
-0@@ -323,6 +323,9 @@ enum {#define AC_PWRST_D1 0x01#define AC_PWRST_D2 0x02#define AC_PWRST_D3 0x03 +#define AC_PWRST_ERROR (1<<8) +#define AC_PWRST_CLK_STOP_OK (1<<9) +#define AC_PWRST_SETTING_RESET (1<<10)/* Processing capabilies */ #define AC_PCAP_BENIGN (1<<0)sound/pci/hda/hda_proc.c +0
-0
sound/pci/hda/hda_proc.c static void print_power_state(struct snd_info_buffer *buffer, · line 463
Quoted 10 lines
sound/pci/hda/hda_proc.c +3
-1@@ -455,10 +455,17 @@ static void print_power_state(struct snd_info_buffer *buffer,snd_iprintf (buffer," Power states: %s\n" ,bits_names (sup, names,ARRAY_SIZE (names))); -snd_iprintf (buffer," Power: setting=%s, actual=%s\n" , +snd_iprintf (buffer," Power: setting=%s, actual=%s" ,get_pwr_state (pwr &AC_PWRST_SETTING ),get_pwr_state ((pwr &AC_PWRST_ACTUAL ) >>AC_PWRST_ACTUAL_SHIFT )); +if (pwr &AC_PWRST_ERROR ) +snd_iprintf (buffer," , Error" );
The space at the beginning should be superfluous.
I applied the patch with that fix now.
thanks,
Takashi