Skip to contentSkip to conversation

pinctrl: pinctrl-imx: free if of_get_parent fails to get the parent node

PATCH Applied Devendra Naga 2 participants 2 messages Jun 7, 2012 – Jun 12, 2012

Subsystems (2)
Arm i.MX and Layerscape Pin control
lore
Share & tools
lore

Devendra Naga

author
#0 lore raw

PATCH v2 2/2 pinctrl: pinctrl-imx: free if of_get_parent fails to get the parent node

of_get_parent can return null if no parent node found, so the allocated new_map should be freed.

Signed-off-by Devendra Naga <[email protected]>
Acked-by Dong Aisheng <[email protected]>
---
 drivers/pinctrl/pinctrl-imx.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pinctrl/pinctrl-imx.c +3 -1
index 7a59a59..59a5fa3 100644
@@ -173,8 +173,10 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev,
 
 	/* create mux map */
 	parent = of_get_parent(np);
-	if (!parent)
+	if (!parent) {
+		kfree(new_map);
 		return -EINVAL;
+	}
 	new_map[0].type = PIN_MAP_TYPE_MUX_GROUP;
 	new_map[0].data.mux.function = parent->name;
 	new_map[0].data.mux.group = np->name;
Signature · 1 line
1.7.9.5