Skip to contentSkip to conversation

mmotm-0716 - selinux_bprm_commited_creds patch missing..

PATCH [email protected] 2 participants 3 messages Jul 23, 2009 SELinux security module

lore
Share & tools
lore
#0 lore raw

Andrew - mmotm-0716 dies at boot because it's missing this patch from Oleg for a problem originally spotted in -0630/0702:

Date: Fri, 03 Jul 2009 11:23:11 +0200
From: Oleg Nesterov <[email protected]>
To: Andrew Morton <[email protected]>
Cc: [email protected], [email protected], James Morris <[email protected]>, David Howells <[email protected]>, Roland McGrath <[email protected]>
Subject: [PATCH] selinux_bprm_committed_creds: use __wake_up_parent()

(depends on ptrace-__ptrace_detach-do-__wake_up_parent-if-we-reap-the-tracee.patch
which exports __wake_up_parent)

Spotted by [email protected].

selinux_bprm_committed_creds() should not play with ->wait_chldexit, now that __wake_up_parent() is exported change the code to use this helper.

security/selinux/hooks.c renamed from security/selinux/hooks.c~SEL_WAKE_PARENT +1 -1
@@ -2404,7 +2404,7 @@ static void selinux_bprm_committed_creds
 	/* Wake up the parent if it is waiting so that it can recheck
 	 * wait permission to the new task SID. */
 	read_lock(&tasklist_lock);
-	wake_up_interruptible(&current->real_parent->signal->wait_chldexit);
+	__wake_up_parent(current, current->real_parent);
 	read_unlock(&tasklist_lock);
 }
 
#1 lore raw
Quoted 8 lines · On 07/23, [email protected] wrote:

Andrew - mmotm-0716 dies at boot because it's missing this patch from Oleg for a problem originally spotted in -0630/0702:

security/selinux/hooks.c static void selinux_bprm_committed_creds · line 2408

Quoted 6 lines
security/selinux/hooks.c renamed from security/selinux/hooks.c~SEL_WAKE_PARENT +1 -1
@@ -2404,7 +2404,7 @@ static void selinux_bprm_committed_creds
 	/* Wake up the parent if it is waiting so that it can recheck
 	 * wait permission to the new task SID. */
 	read_lock(&tasklist_lock);
-	wake_up_interruptible(&current->real_parent->signal->wait_chldexit);
+	__wake_up_parent(current, current->real_parent);
 	read_unlock(&tasklist_lock);

Thanks Valdis! but it is already (since Jul 18) in -mm, do_wait-wakeup-optimization-change-__wake_up_parent-to-use-filtered-wakeup-selinux_bprm_committed_creds-use-__wake_up_parent.patch

Oleg.

#2 lore raw
Quoted 3 lines · Oleg Nesterov

Thanks Valdis! but it is already (since Jul 18) in -mm, do_wait-wakeup-optimization-change-__wake_up_parent-to-use-filtered-wakeup-selinux_bprm_committed_creds-use-__wake_up_parent.patch

"Nevermind.." -- Emily Litella

:)