pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl

PATCH Applied Devendra Naga 3 participants 3 messages Jun 18, 2012 – Jun 20, 2012

Subsystems (2)

Tegra architecture support Pin control

lore

Share & tools

lore

Devendra Naga

author

2012-06-18 17:44 UTC #0 lore raw

PATCH 1/2 pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl

pinctrl_register returns a pointer of struct type struct pinctrl_dev, if successfully registered to pinctrl subsystem, otherwise returns NULL, and there wont' be any pointers which are not dereferencible.

They are not type of pointer addresses but are kind of error codes rather actual addresses, but are a kind of return codes of functions returning integer types.

return -ENODEV if device registration fails.

Signed-off-by Devendra Naga <[email protected]>

---
 drivers/pinctrl/pinctrl-tegra.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/pinctrl/pinctrl-tegra.c +2 -2

index 07228b1..ae52e4e 100644
@@ -745,9 +745,9 @@ int __devinit tegra_pinctrl_probe(struct platform_device *pdev,
 	}
 
 	pmx->pctl = pinctrl_register(&tegra_pinctrl_desc, &pdev->dev, pmx);
-	if (IS_ERR(pmx->pctl)) {
+	if (!pmx->pctl) {
 		dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
-		return PTR_ERR(pmx->pctl);
+		return -ENODEV;
 	}
 
 	pinctrl_add_gpio_range(pmx->pctl, &tegra_pinctrl_gpio_range);

Signature · 1 line

1.7.9.5

Stephen Warren

Acked-by on v1 1/2

2012-06-18 18:05 UTC #1 lore raw

Quoted 11 lines · Devendra Naga

pinctrl_register returns a pointer of struct type struct pinctrl_dev, if successfully registered to pinctrl subsystem, otherwise returns NULL, and there wont' be any pointers which are not dereferencible.
They are not type of pointer addresses but are kind of error codes rather actual addresses, but are a kind of return codes of functions returning integer types.
return -ENODEV if device registration fails.
Signed-off-by Devendra Naga <[email protected]>

Oops.

Acked-by Stephen Warren <[email protected]>

Probably Cc stable since this is wrong back as far as 3.4.

Linus Walleij

2012-06-20 08:04 UTC #2 lore raw

In reply to Devendra Naga

Quoted 11 lines · Devendra Naga

pinctrl_register returns a pointer of struct type struct pinctrl_dev, if successfully registered to pinctrl subsystem, otherwise returns NULL, and there wont' be any pointers which are not dereferencible.
They are not type of pointer addresses but are kind of error codes rather actual addresses, but are a kind of return codes of functions returning integer types.
return -ENODEV if device registration fails.
Signed-off-by Devendra Naga <[email protected]>

Applied with Stephen's ACK, thanks!
Linus Walleij