staging/rtl8192u: fix coding style problems
PATCH v2 2/3 staging/rtl8192u: fix coding style problems
fixed some of the C99 warnings and coding style problems, not only reported checkpatch but while reading the code
Signed-off-by Devendra Naga <[email protected]>
--- drivers/staging/rtl8192u/r8180_93cx6.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
drivers/staging/rtl8192u/r8180_93cx6.c +14 -11
@@ -80,7 +80,7 @@ void eprom_send_bits_string(struct net_device *dev, short b[], int len) {int i; -for (i=0 ; i<len; i++){ +for (i =0 ; i < len; i++) {eprom_w (dev, b[i]);eprom_ck_cycle (dev); }
@@ -90,14 +90,13 @@ void eprom_send_bits_string(struct net_device *dev, short b[], int len)u32 eprom_read (struct net_device *dev,u32 addr) {struct r8192_priv *priv =ieee80211_priv (dev); -short read_cmd[]={1 ,1 ,0 }; +short read_cmd[] = {1 ,1 ,0 };short addr_str[8 ];int i;int addr_len; -u32 ret; +u32 ret =0 ; - ret=0 ; -//enable EPROM programming +/* enable EPROM programming */ write_nic_byte_E (dev,EPROM_CMD , (EPROM_CMD_PROGRAM <<EPROM_CMD_OPERATING_MODE_SHIFT ));force_pci_posting (dev);
@@ -127,13 +126,17 @@ u32 eprom_read(struct net_device *dev, u32 addr)eprom_send_bits_string (dev, read_cmd,3 );eprom_send_bits_string (dev, addr_str, addr_len); -//keep chip pin D to low state while reading. -//I'm unsure if it is necessary, but anyway shouldn't hurt +/** +* keep chip pin D to low state while reading. +* I'm unsure if it is necessary, but anyway shouldn't hurt +*/ eprom_w (dev,0 ); -for (i=0 ;i<16 ;i++){ -//eeprom needs a clk cycle between writing opcode&adr -//and reading data. (eeprom outs a dummy 0) +for (i =0 ; i <16 ; i++) { +/** +* eeprom needs a clk cycle between writing opcode&adr +* and reading data. (eeprom outs a dummy 0) +*/ eprom_ck_cycle (dev); ret |= (eprom_r (dev)<<(15 -i)); }
@@ -141,7 +144,7 @@ u32 eprom_read(struct net_device *dev, u32 addr)eprom_cs (dev,0 );eprom_ck_cycle (dev); -//disable EPROM programming +/* disable EPROM programming */ write_nic_byte_E (dev,EPROM_CMD , (EPROM_CMD_NORMAL <<EPROM_CMD_OPERATING_MODE_SHIFT ));return ret;
Signature · 1 line
1.7.9.5