Skip to contentSkip to conversation

mfd: MFD_MAX77693 needs to select IRQ_DOMAIN

PATCH In review Axel Lin 3 participants 4 messages Jun 20, 2012 – Jul 2, 2012 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: MFD_MAX77693 needs to select IRQ_DOMAIN

This fixes below build errors:

CC drivers/mfd/max77693-irq.o
drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration] drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration] drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Reported-by Randy Dunlap <[email protected]>
Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
index e129c82..79f1d4b 100644
@@ -427,6 +427,7 @@ config MFD_MAX77693
 	depends on I2C=y && GENERIC_HARDIRQS
 	select MFD_CORE
 	select REGMAP_I2C
+	select IRQ_DOMAIN
 	help
 	  Say yes here to support for Maxim Semiconductor MAX77693.
 	  This is a companion Power Management IC with Flash, Haptic, Charger,
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 mfd: TWL6040_CORE needs to select IRQ_DOMAIN

From: Randy Dunlap <[email protected]>

Fix build error by selecting IRQ_DOMAIN:

drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy' drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)

Signed-off-by Randy Dunlap <[email protected]>
Cc Samuel Ortiz <[email protected]>
Cc Misael Lopez Cruz <[email protected]>
---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
@@ -286,6 +286,7 @@ config TWL6040_CORE
 	depends on I2C=y && GENERIC_HARDIRQS
 	select MFD_CORE
 	select REGMAP_I2C
+	select IRQ_DOMAIN
 	default n
 	help
 	  Say yes here if you want support for Texas Instruments TWL6040 audio
#2 lore raw

Re: [PATCH] mfd: TWL6040_CORE needs to select IRQ_DOMAIN

Hi Randy,

Quoted 6 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build error by selecting IRQ_DOMAIN:

drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy' drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)

This should also be fixed with MFD_CORE selecting IRQ_DOMAIN now.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
Acked-by on v1 1/1
#3 lore raw
In reply to Axel Lin
Quoted 13 lines · Axel Lin

This fixes below build errors:

CC drivers/mfd/max77693-irq.o
drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration] drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration] drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Quoted 2 lines
Reported-by Randy Dunlap <[email protected]>
Signed-off-by Axel Lin <[email protected]>
Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 16 lines
---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
index e129c82..79f1d4b 100644
@@ -427,6 +427,7 @@ config MFD_MAX77693
 	depends on I2C=y && GENERIC_HARDIRQS
 	select MFD_CORE
 	select REGMAP_I2C
+	select IRQ_DOMAIN
 	help
 	  Say yes here to support for Maxim Semiconductor MAX77693.
 	  This is a companion Power Management IC with Flash, Haptic, Charger,
Signature · 1 line
~Randy