Skip to contentSkip to conversation

mfd: adp5520: Guard PM methods with CONFIG_PM_SLEEP

PATCH In review Axel Lin 3 participants 3 messages Jul 2, 2012

Subsystems (2)
Multifunction devices (MFD) ADP5520 backlight driver with io expander (ADP5520/ADP5501)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: adp5520: Guard PM methods with CONFIG_PM_SLEEP

This fixes below build warnings:
CC drivers/mfd/adp5520.o
drivers/mfd/adp5520.c:324:12: warning: 'adp5520_suspend' defined but not used [-Wunused-function] drivers/mfd/adp5520.c:333:12: warning: 'adp5520_resume' defined but not used [-Wunused-function]

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/adp5520.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/adp5520.c +1 -1
index 8d816cc..ea8b947 100644
@@ -320,7 +320,7 @@ static int __devexit adp5520_remove(struct i2c_client *client)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int adp5520_suspend(struct device *dev)
 {
 	struct i2c_client *client = to_i2c_client(dev);
Signature · 1 line
1.7.9.5
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Axel Lin

This fixes below build warnings:
CC drivers/mfd/adp5520.o
drivers/mfd/adp5520.c:324:12: warning: 'adp5520_suspend' defined but not used [-Wunused-function] drivers/mfd/adp5520.c:333:12: warning: 'adp5520_resume' defined but not used [-Wunused-function]

Signed-off-by Axel Lin <[email protected]>
Acked-by Michael Hennerich <[email protected]>
Quoted 17 lines
---
  drivers/mfd/adp5520.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/adp5520.c +1 -1
index 8d816cc..ea8b947 100644
@@ -320,7 +320,7 @@ static int __devexit adp5520_remove(struct i2c_client *client)
  	return 0;
  }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
  static int adp5520_suspend(struct device *dev)
  {
  	struct i2c_client *client = to_i2c_client(dev);
Signature · 8 lines
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
#2 lore raw
In reply to Axel Lin

Hi Axel,

Quoted 9 lines · Axel Lin

This fixes below build warnings:
CC drivers/mfd/adp5520.o
drivers/mfd/adp5520.c:324:12: warning: 'adp5520_suspend' defined but not used [-Wunused-function] drivers/mfd/adp5520.c:333:12: warning: 'adp5520_resume' defined but not used [-Wunused-function]

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/adp5520.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, patch applied as well.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/