drm/mgag200: fix null pointer dereference

PATCH New Devendra Naga 1 participant 1 message Jul 7, 2012

Subsystems (3)

DRM drivers DRM misc DRM driver for mga G200 graphics chips

lore

Share & tools

lore

Devendra Naga

author

2012-07-07 09:22 UTC #0 lore raw

PATCH 1/1 drm/mgag200: fix null pointer dereference

we are referencing the pointer after doing alloc_apertures, as alloc_apertures kzallocs, the kzalloc may fail and we get a NULL.

so we need to check for NULL before we dereference this pointer

Signed-off-by Devendra Naga <[email protected]>

---
 drivers/gpu/drm/mgag200/mgag200_drv.c |    3 +++
 1 file changed, 3 insertions(+)

drivers/gpu/drm/mgag200/mgag200_drv.c +3 -0

index 93e832d..ea1024d 100644
@@ -47,6 +47,9 @@ static void mgag200_kick_out_firmware_fb(struct pci_dev *pdev)
 	bool primary = false;
 
 	ap = alloc_apertures(1);
+	if (!ap)
+		return;
+
 	ap->ranges[0].base = pci_resource_start(pdev, 0);
 	ap->ranges[0].size = pci_resource_len(pdev, 0);

Signature · 1 line

1.7.9.5