Skip to contentSkip to conversation

rtc/rtc-da9052: remove unneed devm_kfree call

PATCH New Devendra Naga 1 participant 1 message Jul 18, 2012

Subsystems (2)
Real time clock (RTC) Dialog semiconductor drivers
lore
Share & tools
lore

Devendra Naga

author
#0 lore raw

PATCH 3/3 rtc/rtc-da9052: remove unneed devm_kfree call

freeing will trigger when driver unloads, so using devm_kfree is not needed.

Signed-off-by Devendra Naga <[email protected]>
---
 drivers/rtc/rtc-da9052.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/rtc/rtc-da9052.c +1 -4
index da6ab52..7807025 100644
@@ -245,7 +245,7 @@ static int __devinit da9052_rtc_probe(struct platform_device *pdev)
 				   "ALM", rtc);
 	if (ret != 0) {
 		rtc_err(rtc->da9052, "irq registration failed: %d\n", ret);
-		goto err_mem;
+		return ret;
 	}
 
 	rtc->rtc = rtc_device_register(pdev->name, &pdev->dev,

@@ -259,8 +259,6 @@ static int __devinit da9052_rtc_probe(struct platform_device *pdev)
 
 err_free_irq:
 	free_irq(rtc->irq, rtc);
-err_mem:
-	devm_kfree(&pdev->dev, rtc);
 	return ret;
 }
 

@@ -271,7 +269,6 @@ static int __devexit da9052_rtc_remove(struct platform_device *pdev)
 	rtc_device_unregister(rtc->rtc);
 	free_irq(rtc->irq, rtc);
 	platform_set_drvdata(pdev, NULL);
-	devm_kfree(&pdev->dev, rtc);
 
 	return 0;
 }
Signature · 1 line
1.7.0.4