Skip to contentSkip to conversation

staging/csr: remove firmware pointer check before giving to release_firmware

PATCH New Devendra Naga 1 participant 1 message Jul 21, 2012 Staging

lore
Share & tools
lore

Devendra Naga

author
#0 lore raw

PATCH 3/3 staging/csr: remove firmware pointer check before giving to release_firmware

we do a check of firmware pointer against the NULL value before we give it to the release_firmware.

as release_firmware is actually having a check against NULL, its not needed here.

Signed-off-by Devendra Naga <[email protected]>
---
 drivers/staging/csr/firmware.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/csr/firmware.c +1 -3
index d14e118..dc6a04d 100644
@@ -402,9 +402,7 @@ int uf_release_firmware_files(unifi_priv_t *priv)
 int uf_release_firmware(unifi_priv_t *priv, struct dlpriv *to_free)
 {
     if (to_free != NULL) {
-        if (to_free->fw_desc != NULL) {
-            release_firmware((const struct firmware *)to_free->fw_desc);
-        }
+        release_firmware((const struct firmware *)to_free->fw_desc);
         to_free->fw_desc = NULL;
         to_free->dl_data = NULL;
         to_free->dl_len = 0;
Signature · 1 line
1.7.9.5