Skip to contentSkip to conversation

extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one

PATCH In review Axel Lin 2 participants 2 messages Jul 24, 2012 – Jul 25, 2012 External connector subsystem (extcon)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one

commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one" missed the replacement for devm_gpio_request_one. fix it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/extcon/extcon_gpio.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/extcon/extcon_gpio.c +2 -1
index fe3db45..3cc152e 100644
@@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
 	if (ret < 0)
 		return ret;
 
-	ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
+	ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
+				    pdev->name);
 	if (ret < 0)
 		goto err;
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 13 lines · Axel Lin

commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one" missed the replacement for devm_gpio_request_one. fix it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/extcon/extcon_gpio.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/extcon/extcon_gpio.c +0 -0
index fe3db45..3cc152e 100644

drivers/extcon/extcon_gpio.c static int __devinit gpio_extcon_probe(struct platform_device *pdev) · line 114

Quoted 9 lines
drivers/extcon/extcon_gpio.c +2 -1
@@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
 	if (ret < 0)
 		return ret;
 
-	ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
+	ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
+				    pdev->name);
 	if (ret < 0)
 		goto err;

It is right.

Signed-off-by Chanwoo Choi <[email protected]>

Thank you,
Chanwoo Choi