Skip to contentSkip to conversation

kernel.bbclass: Copy bounds.h only if it exists, needed for 2.6.x.

for denzil Applied [email protected] 3 participants 6 messages Jul 31, 2012 – Aug 1, 2012

lore
Share & tools
lore
#0 lore raw

From: Leon Woestenberg <[email protected]>

Linux 2.6.x kernels did not (all) have the bounds.h file, so copy only iff exists.

(See OE-Core 02ac0d1b65389e1779d5f95047f761d7a82ef7a4)

---
 meta/classes/kernel.bbclass |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
meta/classes/kernel.bbclass +5 -0
index c21ab96..5f6ff66 100644
@@ -183,6 +183,11 @@ kernel_do_install() {
 		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
 	fi
 
+	# Necessary for building modules like compat-wireless.
+	if [ -f include/generated/bounds.h ]; then
+		cp include/generated/bounds.h $kerneldir/include/generated/bounds.h
+	fi
+
 	# Remove the following binaries which cause strip errors
 	# during do_package for cross-compiled platforms
 	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
Signature · 1 line
1.7.0.4
Applied
#1 lore raw
Quoted 19 lines · On 07/31/2012 01:35 PM, [email protected] wrote:

From: Leon Woestenberg <[email protected]>

Linux 2.6.x kernels did not (all) have the bounds.h file, so copy only iff exists.

(See OE-Core 02ac0d1b65389e1779d5f95047f761d7a82ef7a4)

---
  meta/classes/kernel.bbclass |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)
meta/classes/kernel.bbclass +0 -0
index c21ab96..5f6ff66 100644
@@ -183,6 +183,11 @@ kernel_do_install() {
  		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o

meta/classes/kernel.bbclass kernel_do_install() { · line 193

Quoted 10 lines
meta/classes/kernel.bbclass +5 -0
  	fi
 
+	# Necessary for building modules like compat-wireless.
+	if [ -f include/generated/bounds.h ]; then
+		cp include/generated/bounds.h $kerneldir/include/generated/bounds.h
+	fi
+
  	# Remove the following binaries which cause strip errors
  	# during do_package for cross-compiled platforms
  	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \

Merged into my sgarman/denzil-next branches:

http://git.openembedded.org/openembedded-core-contrib/log/?h=sgarman/denzil-next

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgarman/denzil-next

If this passes a round of autobuilder tests, I'll be submitting a pull request to the official denzil branch shortly thereafter.

Thanks,

Scott

Signature · 3 lines
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center
#2 lore raw
Quoted 11 lines · Scott Garman
Quoted 5 lines · On 07/31/2012 01:35 PM, [email protected] wrote:

From: Leon Woestenberg <[email protected]>

Linux 2.6.x kernels did not (all) have the bounds.h file, so copy only iff exists.Merged into my sgarman/denzil-next branches:

http://git.openembedded.org/openembedded-core-contrib/log/?h=sgarman/denzil-next

Quoted 8 lines

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgarman/denzil-next

If this passes a round of autobuilder tests, I'll be submitting a pull request to the official denzil branch shortly thereafter. Thanks,
Scott

Thanks Scott. Also thanks for the pointers to denzil-next. I will

consider adding those to my build rounds locally also.

Regards,

Leon.

#3 lore raw
In reply to [email protected]

Shouldn't this be sent to the oe-core list?!?!?

Op 31 jul. 2012, om 22:35 heeft [email protected] het volgende geschreven:

Quoted 35 lines

From: Leon Woestenberg <[email protected]>

Linux 2.6.x kernels did not (all) have the bounds.h file, so copy only iff exists.

(See OE-Core 02ac0d1b65389e1779d5f95047f761d7a82ef7a4)

---
meta/classes/kernel.bbclass | 5 +++++

1 files changed, 5 insertions(+), 0 deletions(-)
meta/classes/kernel.bbclass +5 -0
index c21ab96..5f6ff66 100644
@@ -183,6 +183,11 @@ kernel_do_install() {
 		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
 	fi
 
+	# Necessary for building modules like compat-wireless.
+	if [ -f include/generated/bounds.h ]; then
+		cp include/generated/bounds.h $kerneldir/include/generated/bounds.h
+	fi
+
 	# Remove the following binaries which cause strip errors
 	# during do_package for cross-compiled platforms
 	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
Signature · 6 lines
1.7.0.4

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
#4 lore raw

Hello Koen,

On 08/01/2012 08:55 AM, Koen Kooi wrote:

Shouldn't this be sent to the oe-core list?!?!?

It was intended for the denzil branch ([for denzil]) of Yocto, that's why I sent it to [email protected].

If that was wrong reasoning, let me know, I would be glad to change workflow if I know why.

Cheers,

Leon.

#5 lore raw
Quoted 10 lines · Leon Woestenberg

Hello Koen,

Quoted 2 lines · Koen Kooi

Shouldn't this be sent to the oe-core list?!?!?

It was intended for the denzil branch ([for denzil]) of Yocto, that's why I sent it to [email protected].

If that was wrong reasoning, let me know, I would be glad to change workflow if I know why.

Hi Leon,

Since Yocto is built upon oe-core, changes to files that live in oe-core should really be sent to the oe-core ML. Our workflow is then to pick things up from oe-core and move them into the poky git repository.

Both oe-core and poky have denzil branches this patch applies to, so you'd still make mention in your subject line that the patch is intended for denzil.

The main reason to submit patches to the Yocto ML is if it's specific to the meta-yocto layer you find in the Poky git repository, or to discuss overall Yocto issues.

Just some things to keep in mind for the future.

Thanks,

Scott

Signature · 3 lines
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center