Skip to contentSkip to conversation

misc: use module_spi_driver

PATCH In review Devendra Naga 2 participants 2 messages Aug 23, 2012 Char and misc drivers

lore
Share & tools
lore

Devendra Naga

author
#0 lore raw

PATCH 1/1 misc: use module_spi_driver

The _init and _exit functions can be replaced with the module_spi_driver macro, which actually implements

static int __init drv_init(void)

{
	spi_register_driver(&driv_op);
	return 0;
}

module_init(drv_init);

static void __exit drv_exit(void)

{
	spi_unregister_driver(&driv_op);
}

module_exit(drv_exit);

Signed-off-by Devendra Naga <[email protected]>
---
 drivers/misc/bmp085-spi.c |   13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
drivers/misc/bmp085-spi.c +1 -12
index 78aaff9..5e982af 100644
@@ -73,19 +73,8 @@ static struct spi_driver bmp085_spi_driver = {
 	.remove		= __devexit_p(bmp085_spi_remove)
 };
 
-static int __init bmp085_spi_init(void)
-{
-	return spi_register_driver(&bmp085_spi_driver);
-}
-
-static void __exit bmp085_spi_exit(void)
-{
-	spi_unregister_driver(&bmp085_spi_driver);
-}
+module_spi_driver(bmp085_spi_driver);
 
 MODULE_AUTHOR("Eric Andersson <[email protected]>");
 MODULE_DESCRIPTION("BMP085 SPI bus driver");
 MODULE_LICENSE("GPL");
-
-module_init(bmp085_spi_init);
-module_exit(bmp085_spi_exit);
Signature · 1 line
1.7.9.5
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Devendra Naga

The _init and _exit functions can be replaced with the module_spi_driver macro, which actually implements

static int __init drv_init(void)

{
        spi_register_driver(&driv_op);
        return 0;
}

module_init(drv_init);

Quoted 8 lines

static void __exit drv_exit(void)

{
        spi_unregister_driver(&driv_op);
}

module_exit(drv_exit);

Signed-off-by Devendra Naga <[email protected]>
Acked-by Arnd Bergmann <[email protected]>