Skip to contentSkip to conversation

kernel.h: Introduce IDIV_ROUND_CLOSEST

PATCH Superseded Guenter Roeck 2 participants 3 messages Aug 25, 2012 – Aug 28, 2012

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel.h: Introduce IDIV_ROUND_CLOSEST

DIV_ROUND_CLOSEST returns a bad result for negative dividends:

	DIV_ROUND_CLOSEST(-2, 2) = 0

Most of the time this does not matter. However, in the hardware monitoring subsystem, it is often used on integers which can be negative (such as temperatures). Introduce new macro IDIV_ROUND_CLOSEST which also supports negative dividends.

---
I can take this patch through my hwmon tree, but would like to get an Ack first. Alternative would be to put it into include/linux/hwmon.h, but I would prefer to avoid that.

Also, if someone has an idea for a simpler implementation, I would really like to know about it.

 include/linux/kernel.h |    9 +++++++++
 1 file changed, 9 insertions(+)
include/linux/kernel.h +9 -0
index 6043821..a89483c 100644
@@ -89,6 +89,15 @@
 }							\
 )
 
+#define IDIV_ROUND_CLOSEST(x, divisor)(			\
+{							\
+	typeof(x) __x = x;				\
+	typeof(divisor) __d1 = divisor;			\
+	typeof(divisor) __d2 = (__x) < 0 ? -(__d1) : (__d1);\
+	(((__x) + ((__d2) / 2)) / (__d1));		\
+}							\
+)
+
 /*
  * Multiplies an integer by a fraction, while avoiding unnecessary
  * overflow or loss of precision.
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Acked-by on v1 1/1
#1 lore raw

Hi Guenter,

Quoted 7 lines · Guenter Roeck

DIV_ROUND_CLOSEST returns a bad result for negative dividends:

	DIV_ROUND_CLOSEST(-2, 2) = 0

Most of the time this does not matter. However, in the hardware monitoring subsystem, it is often used on integers which can be negative (such as temperatures). Introduce new macro IDIV_ROUND_CLOSEST which also supports negative dividends.

Good catch. It's been broken for years and I never noticed :(

Quoted 6 lines

---
I can take this patch through my hwmon tree, but would like to get an Ack first. Alternative would be to put it into include/linux/hwmon.h, but I would prefer to avoid that.

I agree it should sit next to DIV_ROUND_CLOSEST in <linux/kernel.h>.

Quoted 3 lines

Also, if someone has an idea for a simpler implementation, I would really like to know about it.

I can't think of anything better.

Note that your implementation only supports negative dividend not divisor. While it won't be a problem for hwmon drivers, and most probably not a problem for other drivers either, it might be worth putting in a comment so as to prevent false expectations from the reader.

Quoted 24 lines
 include/linux/kernel.h |    9 +++++++++
 1 file changed, 9 insertions(+)
include/linux/kernel.h +9 -0
index 6043821..a89483c 100644
@@ -89,6 +89,15 @@
 }							\
 )
 
+#define IDIV_ROUND_CLOSEST(x, divisor)(			\
+{							\
+	typeof(x) __x = x;				\
+	typeof(divisor) __d1 = divisor;			\
+	typeof(divisor) __d2 = (__x) < 0 ? -(__d1) : (__d1);\
+	(((__x) + ((__d2) / 2)) / (__d1));		\
+}							\
+)
+
 /*
  * Multiplies an integer by a fraction, while avoiding unnecessary
  * overflow or loss of precision.
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw
Quoted 28 lines · Jean Delvare

Hi Guenter,

Quoted 7 lines · Guenter Roeck

DIV_ROUND_CLOSEST returns a bad result for negative dividends:

	DIV_ROUND_CLOSEST(-2, 2) = 0

Most of the time this does not matter. However, in the hardware monitoring subsystem, it is often used on integers which can be negative (such as temperatures). Introduce new macro IDIV_ROUND_CLOSEST which also supports negative dividends.

Good catch. It's been broken for years and I never noticed :(

Quoted 6 lines

---
I can take this patch through my hwmon tree, but would like to get an Ack first. Alternative would be to put it into include/linux/hwmon.h, but I would prefer to avoid that.

I agree it should sit next to DIV_ROUND_CLOSEST in <linux/kernel.h>.

Quoted 3 lines

Also, if someone has an idea for a simpler implementation, I would really like to know about it.

Quoted 8 lines

I can't think of anything better.

Note that your implementation only supports negative dividend not divisor. While it won't be a problem for hwmon drivers, and most probably not a problem for other drivers either, it might be worth putting in a comment so as to prevent false expectations from the reader.

I noticed. I am not concerned about negative divisors, though, but unsigned divisor variables are a problem too. I have a new version which also supports divisors which are declared as unsigned.

Thanks,
Guenter

Quoted 29 lines
Quoted 24 lines
 include/linux/kernel.h |    9 +++++++++
 1 file changed, 9 insertions(+)
include/linux/kernel.h +9 -0
index 6043821..a89483c 100644
@@ -89,6 +89,15 @@
 }							\
 )
 
+#define IDIV_ROUND_CLOSEST(x, divisor)(			\
+{							\
+	typeof(x) __x = x;				\
+	typeof(divisor) __d1 = divisor;			\
+	typeof(divisor) __d2 = (__x) < 0 ? -(__d1) : (__d1);\
+	(((__x) + ((__d2) / 2)) / (__d1));		\
+}							\
+)
+
 /*
  * Multiplies an integer by a fraction, while avoiding unnecessary
  * overflow or loss of precision.
Signature · 1 line
Jean Delvare