Skip to contentSkip to conversation

x86/mm/init.c: devmem_is_allowed() off by one

PATCH In review T Makphaibulchoke 1 participant 2 messages Aug 29, 2012 – Sep 14, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mm/init.c: devmem_is_allowed() off by one

Fixing an off-by-one error in devmem_is_allowed(), which allows accesses to physical addresses 0x100000-0x100fff, an extra page past 1MB.

---
 arch/x86/mm/init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/mm/init.c +1 -1
index e0e6990..ab1f6a9 100644
@@ -319,7 +319,7 @@ unsigned long __init_refok init_memory_mapping(unsigned long start,
  */
 int devmem_is_allowed(unsigned long pagenr)
 {
-	if (pagenr <= 256)
+	if (pagenr < 256)
 		return 1;
 	if (iomem_is_exclusive(pagenr << PAGE_SHIFT))
 		return 0;
Signature · 1 line
1.7.1
#1 lore raw

[tip:x86/urgent] x86/mm/init.c: Fix devmem_is_allowed() off by one

Commit-ID:  73e8f3d7e2cb23614d5115703d76d8e54764b641
Gitweb:     http://git.kernel.org/tip/73e8f3d7e2cb23614d5115703d76d8e54764b641
Author:     T Makphaibulchoke <[email protected]>
AuthorDate: Tue, 28 Aug 2012 21:21:43 -0600
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 13 Sep 2012 17:35:54 +0200

x86/mm/init.c: Fix devmem_is_allowed() off by one

Fixing an off-by-one error in devmem_is_allowed(), which allows accesses to physical addresses 0x100000-0x100fff, an extra page past 1MB.

---
 arch/x86/mm/init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/mm/init.c +1 -1
index e0e6990..ab1f6a9 100644
@@ -319,7 +319,7 @@ unsigned long __init_refok init_memory_mapping(unsigned long start,
  */
 int devmem_is_allowed(unsigned long pagenr)
 {
-	if (pagenr <= 256)
+	if (pagenr < 256)
 		return 1;
 	if (iomem_is_exclusive(pagenr << PAGE_SHIFT))
 		return 0;