drm/i915/edp: get the panel delay before powering up
Subsystems (2)
Dave Airlie
maintainerPATCH 1/1 drm/i915/edp: get the panel delay before powering up
In order to setup the i2c channel, we power up the panel via ironlake_edp_panel_vdd_on, however it requires intel_dp->panel_power_up_delay to be initialised, which hasn't been setup yet.
So move things around so we set the panel power up values first then init the i2c stuff.
This is one step to fixing the eDP panel in the MBP from uninitialised state.
--- drivers/gpu/drm/i915/intel_dp.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +7 -4
@@ -2533,14 +2533,10 @@ intel_dp_init(struct drm_device *dev, int output_reg)break ; } -intel_dp_i2c_init (intel_dp, intel_connector, name); -/* Cache some DPCD data in the eDP case */ if (is_edp (intel_dp)) { -bool ret;struct edp_power_seq cur, vbt;u32 pp_on, pp_off, pp_div; -struct edid *edid; pp_on =I915_READ (PCH_PP_ON_DELAYS ); pp_off =I915_READ (PCH_PP_OFF_DELAYS );
@@ -2591,6 +2587,13 @@ intel_dp_init(struct drm_device *dev, int output_reg)DRM_DEBUG_KMS ("backlight on delay %d, off delay %d\n" , intel_dp->backlight_on_delay, intel_dp->backlight_off_delay); + } + +intel_dp_i2c_init (intel_dp, intel_connector, name); + +if (is_edp (intel_dp)) { +bool ret; +struct edid *edid;ironlake_edp_panel_vdd_on (intel_dp); ret =intel_dp_get_dpcd (intel_dp);
Signature · 1 line
1.7.11.2
Daniel Vetter
AppliedQuoted 5 lines · Dave Airlie
In order to setup the i2c channel, we power up the panel via
ironlake_edp_panel_vdd_on, however it requiresintel_dp->panel_power_up_delayto be initialised, which hasn't been setup yet.
Quoted 7 lines
So move things around so we set the panel power up values first then init the i2c stuff.
This is one step to fixing the eDP panel in the MBP from uninitialised state.
Signed-off-by Dave Airlie <[email protected]>
Picked up for -fixes, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48