Skip to contentSkip to conversation

fat (exportfs): rebuild inode if ilookup() fails

PATCH Superseded Namjae Jeon 1 participant 1 message Sep 4, 2012 VFAT/FAT/msdos filesystem

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/5 fat (exportfs): rebuild inode if ilookup() fails

From: Namjae Jeon <[email protected]>

Since the previous patch in this patch-set uses i_pos as the inode number, we can use it to find the directory entry of the inode and subsequently rebuild the inode if the cache lookups fail.

Since this involves accessing the FAT media,it is better to do this only if the 'nfs' mount option is enabled.

---
 fs/fat/nfs.c |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
fs/fat/nfs.c +25 -0
index ef4b5fa..72e62f2 100644
@@ -52,6 +52,31 @@ static struct inode *fat_nfs_get_inode(struct super_block *sb,
 		iput(inode);
 		inode = NULL;
 	}
+	if (inode == NULL && MSDOS_SB(sb)->options.nfs) {
+		struct buffer_head *bh = NULL;
+		struct msdos_dir_entry *de ;
+		loff_t i_pos = (loff_t)ino;
+		int bits = MSDOS_SB(sb)->dir_per_block_bits;
+		loff_t blocknr = i_pos >> bits;
+		bh = sb_bread(sb, blocknr);
+		if (!bh) {
+			fat_msg(sb, KERN_ERR,
+				"unable to read block(%llu) for building NFS inode",
+				(llu)blocknr);
+			return inode;
+		}
+		de = (struct msdos_dir_entry *)bh->b_data;
+		/* If a file is deleted on server and client is not updated
+		 * yet, we must not build the inode upon a lookup call.
+		 */
+		if (de[i_pos&((1<<bits)-1)].name[0] == DELETED_FLAG)
+
+			inode = NULL;
+		else
+			inode = fat_build_inode(sb, &de[i_pos&((1<<bits)-1)],
+					i_pos);
+		brelse(bh);
+	}
 
 	return inode;
 }
Signature · 1 line
1.7.9.5