Drivers: hv: kvp: Copy the address family information
PATCH 1/1 Drivers: hv: kvp: Copy the address family information
Copy the address family information.
--- drivers/hv/hv_kvp.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/hv/hv_kvp.c +2 -0
@@ -256,6 +256,8 @@ static int process_ob_ipinfo(void *in_msg, void *out_msg, int op) out->kvp_ip_val.dhcp_enabled = in->body.kvp_ip_val.dhcp_enabled; + out->kvp_ip_val.addr_family = + in->body.kvp_ip_val.addr_family; }return 0 ;
Signature · 1 line
1.7.4.1
Quoted 1 line · K. Y. Srinivasan
Copy the address family information.
Why?
Quoted 10 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Tuesday, September 04, 2012 6:57 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
Quoted 4 lines
Quoted 1 line · K. Y. Srinivasan
Copy the address family information.
Why?
This is part of the IP injection protocol in that the host expects this field to reflect what addresses (address families) are currently bound to the interface. The KVP daemon is currently collecting this Information and sending it to the kernel component. I had overlooked copying this and sending it back to the host. This patch addresses this issue.
Regards,
K. Y
Quoted 11 lines · KY Srinivasan
Quoted 11 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Tuesday, September 04, 2012 6:57 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family informationOn Tue, Sep 04, 2012 at 03:20:19PM -0700, K. Y. Srinivasan wrote:
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Copy the address family information.
Why?
This is part of the IP injection protocol in that the host expects this field to reflect what addresses (address families) are currently bound to the interface. The KVP daemon is currently collecting this Information and sending it to the kernel component. I had overlooked copying this and sending it back to the host. This patch addresses this issue.
That's nice and descriptive, any reason you didn't put it in the patch changelog section the first time?
Please redo this...
greg k-h
Quoted 32 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Tuesday, September 04, 2012 8:03 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family informationQuoted 7 lines · KY Srinivasan
Quoted 7 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Tuesday, September 04, 2012 6:57 PM
To: KY Srinivasan
Cc: [email protected]; [email protected];Quoted 2 lines
Quoted 2 lines
[email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address familyinformation
Quoted 7 lines
Quoted 5 lines · K. Y. Srinivasan
Quoted 1 line
Copy the address family information.
Why?
This is part of the IP injection protocol in that the host expects this field to
reflect what addresses
Quoted 1 line
(address families) are currently bound to the interface. The KVP daemon is
currently collecting this
Quoted 8 lines
Quoted 1 line
Information and sending it to the kernel component. I had overlooked copying
this and sending it
Quoted 1 line
back to the host. This patch addresses this issue.
That's nice and descriptive, any reason you didn't put it in the patch changelog section the first time?
Please redo this...
Will do.
Regards,
K. Y
Quoted 4 lines
greg k-h