Skip to contentSkip to conversation

libkms: fix the name of the intel driver in linux_sysfs_create

PATCH In review Ander Conselvan de Oliveira 1 participant 2 messages Sep 5, 2012 – Oct 29, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libkms: fix the name of the intel driver in linux_sysfs_create

From: Ander Conselvan de Oliveira <[email protected]>

linux_sysfs_create() checked for a driver named "intel" while the intel driver is called "i915". This went unnoticed because in kernels 2.6.39 and after this code path was never reached because of the dumb buffer interface. On earlier kernels, kms_create() would fail.

---
 libkms/linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
libkms/linux.c +1 -1
index fc4f205..dde74f7 100644
@@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
 	if (ret)
 		return ret;
 
-	if (!strcmp(name, "intel"))
+	if (!strcmp(name, "i915"))
 		ret = intel_create(fd, out);
 #ifdef HAVE_VMWGFX
 	else if (!strcmp(name, "vmwgfx"))
Signature · 1 line
1.7.4.1
#1 lore raw

Ping?

Quoted 26 lines · Ander Conselvan de Oliveira

From: Ander Conselvan de Oliveira <[email protected]>

linux_sysfs_create() checked for a driver named "intel" while the intel driver is called "i915". This went unnoticed because in kernels 2.6.39 and after this code path was never reached because of the dumb buffer interface. On earlier kernels, kms_create() would fail.

---
  libkms/linux.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
libkms/linux.c +1 -1
index fc4f205..dde74f7 100644
@@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
  	if (ret)
  		return ret;
 
-	if (!strcmp(name, "intel"))
+	if (!strcmp(name, "i915"))
  		ret = intel_create(fd, out);
  #ifdef HAVE_VMWGFX
  	else if (!strcmp(name, "vmwgfx"))