Skip to contentSkip to conversation

regulator: fan53555: vsel_max does not match with the max voltage?

DISCUSSION Axel Lin 2 participants 2 messages Sep 10, 2012

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

Hi Yunfan,
Just found below issue while reading the code:

For FAN53555_CHIP_ID_04,

        di->vsel_min = 603000;
        di->vsel_max = 1411000;
        di->vsel_step = 12826;

So we have below voltage list for FAN53555_CHIP_ID_04:

volt[0] = 603000
volt[1] = 615826
volt[2] = 628652
volt[3] = 641478
volt[4] = 654304
volt[5] = 667130

.......

volt[60] = 1372560
volt[61] = 1385386
volt[62] = 1398212
volt[63] = 1411038

Then volt[63] is greater than the vsel_max now.
This looks does not make sense.

Regards,
Axel

#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: 2012年9月10日 11:05
To: Yunfan Zhang
Cc: Liam Girdwood; Mark Brown; [email protected]
Subject: regulator: fan53555: vsel_max does not match with the max voltage?

Hi Yunfan,
Just found below issue while reading the code:

Quoted 8 lines

For FAN53555_CHIP_ID_04,

        di->vsel_min = 603000;
        di->vsel_max = 1411000;
        di->vsel_step = 12826;

volt[63] = 1411038

Then volt[63] is greater than the vsel_max now.
This looks does not make sense.

Axel, Thanks for your findings!
Yes, the volt[63] is GT the vsel_max. Actually vsel_max is not used... The max voltage will be bounded by desc->n_voltages. I will make a patch to remove it to avoid confusing. Thanks a lot! ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�