Minimal RAS stuff
cover Minimal RAS stuff
From: Borislav Petkov <[email protected]>
Ok,
my main intention for this is patch 1/2 which enables MCA by default. I still see bugreports where CONFIG_X86_MCE is disabled and this is a bad idea so turning it on by default makes sense to me.
The second patch is only a cleanup.
Thanks.
Borislav Petkov (2):
x86, mce: Enable MCA support by default
x86, MCE: Remove unused defines
arch/x86/Kconfig | 1 + arch/x86/include/asm/mce.h | 12 +----------- 2 files changed, 2 insertions(+), 11 deletions(-)
Signature · 1 line
1.7.11.rc1
PATCH 1/2 x86, mce: Enable MCA support by default
From: Borislav Petkov <[email protected]>
MCA is the basic support for hardware error logging and reporting, and it is majorly unwise to run without it so enable machine check software support by default on x86.
--- arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/x86/Kconfig +1 -0
@@ -871,6 +871,7 @@ config X86_REROUTE_FOR_BROKEN_BOOT_IRQS config X86_MCE bool "Machine Check / overheating reporting" + default y ---help--- Machine Check support allows the processor to notify the kernel if it detects a problem (e.g. overheating, data corruption).
Signature · 1 line
1.7.11.rc1
RE: [PATCH 1/2] x86, mce: Enable MCA support by default
Quoted 3 lines
MCA is the basic support for hardware error logging and reporting, and it is majorly unwise to run without it so enable machine check software support by default on x86.
Re: [PATCH 1/2] x86, mce: Enable MCA support by default
Quoted 5 lines · Tony
Quoted 3 lines
MCA is the basic support for hardware error logging and reporting, and it is majorly unwise to run without it so enable machine check software support by default on x86.
Acked-by Tony Luck <[email protected]>
Thanks Tony.
Will send a pull request shortly.
Signature · 8 lines
Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
Mauro Carvalho Chehab
Acked-byRe: [PATCH 1/2] x86, mce: Enable MCA support by default
Em 17-09-2012 14:32, Borislav Petkov escreveu:
Quoted 10 lines · Tony
Quoted 5 lines
Quoted 3 lines
MCA is the basic support for hardware error logging and reporting, and it is majorly unwise to run without it so enable machine check software support by default on x86.
Acked-by Tony Luck <[email protected]>Thanks Tony.
Will send a pull request shortly.
Sounds fine for me too. You can add my ack.
Quoted 1 line
PATCH 2/2 x86, MCE: Remove unused defines
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Those were sitting there unused since the dawn of time, drop them.
--- arch/x86/include/asm/mce.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
arch/x86/include/asm/mce.h +1 -11
@@ -116,19 +116,9 @@ struct mce_log {/* Software defined banks */ #define MCE_EXTENDED_BANK 128#define MCE_THERMAL_BANK MCE_EXTENDED_BANK + 0 - -#define K8_MCE_THRESHOLD_BASE (MCE_EXTENDED_BANK + 1)/* MCE_AMD */ -#define K8_MCE_THRESHOLD_BANK_0 (MCE_THRESHOLD_BASE + 0 * 9) -#define K8_MCE_THRESHOLD_BANK_1 (MCE_THRESHOLD_BASE + 1 * 9) -#define K8_MCE_THRESHOLD_BANK_2 (MCE_THRESHOLD_BASE + 2 * 9) -#define K8_MCE_THRESHOLD_BANK_3 (MCE_THRESHOLD_BASE + 3 * 9) -#define K8_MCE_THRESHOLD_BANK_4 (MCE_THRESHOLD_BASE + 4 * 9) -#define K8_MCE_THRESHOLD_BANK_5 (MCE_THRESHOLD_BASE + 5 * 9) -#define K8_MCE_THRESHOLD_DRAM_ECC (MCE_THRESHOLD_BANK_4 + 0) - +#define K8_MCE_THRESHOLD_BASE (MCE_EXTENDED_BANK + 1)#ifdef __KERNEL__ -extern void mce_register_decode_chain (struct notifier_block *nb);extern void mce_unregister_decode_chain (struct notifier_block *nb);
Signature · 1 line
1.7.11.rc1