kexec-tools: admit mips as a COMPATIBLE_HOST
PATCH 1/1 kexec-tools: admit mips as a COMPATIBLE_HOST
--- meta/recipes-kernel/kexec/kexec-tools.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/kexec/kexec-tools.inc +1 -1
@@ -12,6 +12,6 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz inherit autotools -COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)' INSANE_SKIP_${PN} = "arch"
Signature · 1 line
1.7.10.4
meta/recipes-kernel/kexec/kexec-tools.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz · line 15
Quoted 3 lines · Phil Blundell
meta/recipes-kernel/kexec/kexec-tools.inc +1
-1-COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)'
I wonder if this expression should be removed completely now that mips is added we dont have any supported arch left.
Quoted 7 lines · Khem Raj
meta/recipes-kernel/kexec/kexec-tools.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz · line 15
Quoted 3 lines · Phil Blundell
meta/recipes-kernel/kexec/kexec-tools.inc +1
-1-COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)'I wonder if this expression should be removed completely now that mips is added we dont have any supported arch left.
All the powerpc64 target still won't work (the Freescale ones at least).
-M
Quoted 5 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Quoted 10 lines · On Mon, Sep 24, 2012 at 12:10 PM, McClintock Matthew-B29882…
Quoted 7 lines · Khem Raj
meta/recipes-kernel/kexec/kexec-tools.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz · line 15
Quoted 3 lines · Phil Blundell
meta/recipes-kernel/kexec/kexec-tools.inc +1
-1-COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)'I wonder if this expression should be removed completely now that mips is added we dont have any supported arch left.
All the powerpc64 target still won't work (the Freescale ones at least).
OK but above expression does not exclude ppc64 so you have a bug here.
Quoted 8 lines
-M
Quoted 5 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Quoted 7 lines · Khem Raj
meta/recipes-kernel/kexec/kexec-tools.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz · line 15
Quoted 3 lines · Phil Blundell
meta/recipes-kernel/kexec/kexec-tools.inc +1
-1-COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)'I wonder if this expression should be removed completely now that mips is added we dont have any supported arch left.
There are at least a few Linux architectures not in that list: alpha and sparc are the obvious two, but there are a few more obscure ones as well. I don't think alpha has ever really been supported in oe-core, but there are at least some sparc bits in there and, of course, it is possible for an external layer to add support for new architectures. Plus, of course, there is the OS side: if you were targetting mingw32 for example then kexec-tools would clearly not work.
However, all that said, I tend to agree that the COMPATIBLE_HOST check isn't buying much in this recipe. The original intent of COMPATIBLE_MACHINE (and later COMPATIBLE_HOST) was to prevent bitbake from selecting inappropriate providers to satisfy a virtual dependency:
in particular, the idea was that it would stop you picking up a kernel recipe for some completely unrelated hardware. In the case of kexec-tools there are no alternative providers available and it isn't totally obvious that having the recipe skip itself on a host that it thinks is "unsupported" is really any better than letting it try and fail to build. So I would be happy to see that check removed.
p.
Quoted 17 lines · Phil Blundell
Quoted 7 lines · Khem Raj
meta/recipes-kernel/kexec/kexec-tools.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz · line 15
Quoted 3 lines · Phil Blundell
meta/recipes-kernel/kexec/kexec-tools.inc +1
-1-COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)'I wonder if this expression should be removed completely now that mips is added we dont have any supported arch left.
There are at least a few Linux architectures not in that list: alpha and sparc are the obvious two, but there are a few more obscure ones as well. I don't think alpha has ever really been supported in oe-core, but there are at least some sparc bits in there and, of course, it is possible for an external layer to add support for new architectures. Plus, of course, there is the OS side: if you were targetting mingw32 for example then kexec-tools would clearly not work.
Quoted 10 lines
However, all that said, I tend to agree that the
COMPATIBLE_HOSTcheck isn't buying much in this recipe. The original intent ofCOMPATIBLE_MACHINE(and laterCOMPATIBLE_HOST) was to prevent bitbake from selecting inappropriate providers to satisfy a virtual dependency:
in particular, the idea was that it would stop you picking up a kernel recipe for some completely unrelated hardware. In the case of kexec-tools there are no alternative providers available and it isn't totally obvious that having the recipe skip itself on a host that it thinks is "unsupported" is really any better than letting it try and fail to build. So I would be happy to see that check removed.
Going back in time, kexec only worked on a handful of platforms so the check made sense. Now mips support is there, it can probably be removed.
Part of the reasoning this is here is to make world builds useful as a test that everything builds.
Cheers,
Richard
Saul Wold
AppliedQuoted 11 lines · Phil Blundell
Signed-off-by Phil Blundell <[email protected]>--- meta/recipes-kernel/kexec/kexec-tools.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-kernel/kexec/kexec-tools.inc +0
-0
meta/recipes-kernel/kexec/kexec-tools.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz · line 17
Quoted 7 lines
meta/recipes-kernel/kexec/kexec-tools.inc +1
-1@@ -12,6 +12,6 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz inherit autotools -COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-(linux|freebsd.*)' +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*|mips.*)-(linux|freebsd.*)' INSANE_SKIP_${PN} = "arch"
Merged into OE-Core
Sau!