fs/block_dev.c: need not to check inode->i_bdev in bd_forget()
Subsystems (2)
PATCH 1/3 fs/block_dev.c: need not to check inode->i_bdev in bd_forget()
Its only caller evict() has promised a non-NULL inode->i_bdev.
Signed-off-by Yan Hong <[email protected]>
--- fs/block_dev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
fs/block_dev.c +3 -5
@@ -669,11 +669,9 @@ void bd_forget(struct inode *inode)struct block_device *bdev =NULL ;spin_lock (&bdev_lock); -if (inode->i_bdev) { -if (!sb_is_blkdev_sb (inode->i_sb)) - bdev = inode->i_bdev; -__bd_forget (inode); - } +if (!sb_is_blkdev_sb (inode->i_sb)) + bdev = inode->i_bdev; +__bd_forget (inode);spin_unlock (&bdev_lock);if (bdev)
Signature · 1 line
1.7.9.5
PATCH 2/3 fs/debugsfs: get rid of unnecessary inode->i_private initialization
inode->i_private is promised to be NULL on allocation, no need to set it explicitly.
Signed-off-by Yan Hong <[email protected]>
--- fs/debugfs/inode.c | 1 - 1 file changed, 1 deletion(-)
fs/debugfs/inode.c +0 -1
@@ -59,7 +59,6 @@ static struct inode *debugfs_get_inode(struct super_block *sb, umode_t mode, devcase S_IFDIR : inode->i_op = &simple_dir_inode_operations; inode->i_fop = &simple_dir_operations; - inode->i_private =NULL ;/* directory inodes start off with i_nlink == 2 * (for "." entry) */
Signature · 1 line
1.7.9.5
PATCH 3/3 fs/fs-writeback.c: remove unneccesary parameter of __writeback_single_inode()
In reply to Yan HongThe parameter 'wb' is never used in this function.
Cc Wu Fengguang <[email protected]>
Signed-off-by Yan Hong <[email protected]>
--- fs/fs-writeback.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
fs/fs-writeback.c +3 -4
@@ -438,8 +438,7 @@ static void requeue_inode(struct inode *inode, struct bdi_writeback *wb,* setting I_SYNC flag and calling inode_sync_complete() to clear it. */ static int -__writeback_single_inode (struct inode *inode,struct bdi_writeback *wb, -struct writeback_control *wbc) +__writeback_single_inode (struct inode *inode,struct writeback_control *wbc) {struct address_space *mapping = inode->i_mapping;long nr_to_write = wbc->nr_to_write;
@@ -526,7 +525,7 @@ writeback_single_inode(struct inode *inode, struct bdi_writeback *wb, inode->i_state |=I_SYNC ;spin_unlock (&inode->i_lock); - ret =__writeback_single_inode (inode, wb, wbc); + ret =__writeback_single_inode (inode, wbc);spin_lock (&wb->list_lock);spin_lock (&inode->i_lock);
@@ -673,7 +672,7 @@ static long writeback_sb_inodes(struct super_block *sb,* We use I_SYNC to pin the inode in memory. While it is set * evict_inode() will wait so the inode cannot be freed. */ -__writeback_single_inode (inode, wb, &wbc); +__writeback_single_inode (inode, &wbc); work->nr_pages -= write_chunk - wbc.nr_to_write; wrote += write_chunk - wbc.nr_to_write;
Signature · 1 line
1.7.9.5
Re: [PATCH 3/3] fs/fs-writeback.c: remove unneccesary parameter of __writeback_single_inode()
Quoted 1 line · Yan Hong
The parameter 'wb' is never used in this function.
Good spot!
Acked-by Fengguang Wu <[email protected]>