Skip to contentSkip to conversation

pkgconfig: Drop automatic pkgconfig RDEPENDS

RFC PATCH In review Richard Purdie 2 participants 2 messages Oct 8, 2012

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 pkgconfig: Drop automatic pkgconfig RDEPENDS

Just because a recipe uses pkgconfig, it doesn't mean that it's -dev package should RDEPENDS on pkgconfig. I can understand the thinking that lead to this but it makes sense to be able to install the package when pkgconfig hasn't been built.

Currently you can also get failures where pkgconfig wasn't built yet a -dev package is included that depends on it leading to rootfs failures.

I considered making this a RRECOMMENDS but it should probably be an RSUGGESTS at best given the tenuous pkgconfig requirement any given -dev package has. In the end I decided we might as well just remove it.

---

meta/classes/pkgconfig.bbclass +0 -5
index 5908b7f..ad1f84f 100644
@@ -1,7 +1,2 @@
 DEPENDS_prepend = "pkgconfig-native "
 
-PKGCONFIGRDEP = "pkgconfig"
-PKGCONFIGRDEP_virtclass-native = ""
-PKGCONFIGRDEP_virtclass-nativesdk = "nativesdk-pkgconfig"
-
-RDEPENDS_${PN}-dev += "${PKGCONFIGRDEP}"

--
cgit 0.9.0.1

#1 lore raw
Quoted 11 lines · Richard Purdie

Just because a recipe uses pkgconfig, it doesn't mean that it's -dev package should RDEPENDS on pkgconfig. I can understand the thinking that lead to this but it makes sense to be able to install the package when pkgconfig hasn't been built.

Currently you can also get failures where pkgconfig wasn't built yet a -dev package is included that depends on it leading to rootfs failures.

I considered making this a RRECOMMENDS but it should probably be an RSUGGESTS at best given the tenuous pkgconfig requirement any given -dev package has. In the end I decided we might as well just remove it.

I believe the rpmdeps stuff will also add a runtime pkgconfig dependency if it encounters a .pc file during processing.

I know this was debated in the past on various workstation/server distros and the end result came about because it was cheaper to include pkgconfig when a -dev package had a .pc file in it, then support users who couldn't figure out how to properly compiler the stuff on their own.

If we want to change that behavior, then we'll likely have to filter it later as well.

--Mark

Quoted 24 lines

---

meta/classes/pkgconfig.bbclass +0 -6
index 5908b7f..ad1f84f 100644
@@ -1,7 +1,2 @@
  DEPENDS_prepend = "pkgconfig-native "
 
-PKGCONFIGRDEP = "pkgconfig"
-PKGCONFIGRDEP_virtclass-native = ""
-PKGCONFIGRDEP_virtclass-nativesdk = "nativesdk-pkgconfig"
-
-RDEPENDS_${PN}-dev += "${PKGCONFIGRDEP}"
--

cgit 0.9.0.1

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core