drm/i915: fix non-DP-D eDP backlight cleanup and module reload
Subsystems (2)
PATCH 1/1 drm/i915: fix non-DP-D eDP backlight cleanup and module reload
Backlight is initialized for eDP, but cleaned up only for eDP on DP-D port. This leaves behind a dangling backlight interface on module unload on machines that have eDP connected to something other than DP-D, and breaks the backlight interface for subsequent module reloads. Fix the cleanup, and thus module reload on affected machines.
--- drivers/gpu/drm/i915/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +2 -1
@@ -2386,8 +2386,9 @@ static void intel_dp_destroy(struct drm_connector *connector) {struct drm_device *dev = connector->dev; +struct intel_dp *intel_dp =intel_attached_dp (connector); -if (intel_dpd_is_edp (dev)) +if (is_edp (intel_dp))intel_panel_destroy_backlight (dev);drm_sysfs_connector_remove (connector);
Signature · 1 line
1.7.9.5
Quoted 8 lines · Jani Nikula
Backlight is initialized for eDP, but cleaned up only for eDP on DP-D port. This leaves behind a dangling backlight interface on module unload on machines that have eDP connected to something other than DP-D, and breaks the backlight interface for subsequent module reloads. Fix the cleanup, and thus module reload on affected machines.
Reported-by Imre Deak <[email protected]>Signed-off-by Jani Nikula <[email protected]>
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Daniel Vetter
AppliedQuoted 11 lines · Mika Kuoppala
Quoted 8 lines · Jani Nikula
Backlight is initialized for eDP, but cleaned up only for eDP on DP-D port. This leaves behind a dangling backlight interface on module unload on machines that have eDP connected to something other than DP-D, and breaks the backlight interface for subsequent module reloads. Fix the cleanup, and thus module reload on affected machines.
Reported-by Imre Deak <[email protected]>Signed-off-by Jani Nikula <[email protected]>Reviewed-by Mika Kuoppala <[email protected]>
Picked up for -fixes, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 8 lines · Jani Nikula
Backlight is initialized for eDP, but cleaned up only for eDP on DP-D port. This leaves behind a dangling backlight interface on module unload on machines that have eDP connected to something other than DP-D, and breaks the backlight interface for subsequent module reloads. Fix the cleanup, and thus module reload on affected machines.
Reported-by Imre Deak <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Can't reproduce the problem with this:
Quoted 19 lines
--- drivers/gpu/drm/i915/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +2
-1@@ -2386,8 +2386,9 @@ static void intel_dp_destroy(struct drm_connector *connector) {struct drm_device *dev = connector->dev; +struct intel_dp *intel_dp =intel_attached_dp (connector); -if (intel_dpd_is_edp (dev)) +if (is_edp (intel_dp))intel_panel_destroy_backlight (dev);drm_sysfs_connector_remove (connector);