Skip to contentSkip to conversation

DRM/i915: Don't clone SDVO LVDS with analog.

PATCH In review Egbert Eich 2 participants 2 messages Oct 13, 2012 – Oct 16, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DRM/i915: Don't clone SDVO LVDS with analog.

SDVO LVDS are not clonable as the input mode gets adjusted by the LVDS encoder.

---
 drivers/gpu/drm/i915/intel_sdvo.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +2 -4
index d192ce4..d2e8c9f 100644
@@ -2286,10 +2286,8 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 		intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS1;
 	}
 
-	/* SDVO LVDS is cloneable because the SDVO encoder does the upscaling,
-	 * as opposed to native LVDS, where we upscale with the panel-fitter
-	 * (and hence only the native LVDS resolution could be cloned). */
-	intel_sdvo->base.cloneable = true;
+	/* SDVO LVDS is not cloneable because the input mode gets adjusted by the encoder */
+	intel_sdvo->base.cloneable = false;
 
 	intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
 	if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
Signature · 1 line
1.7.6.3
#1 lore raw
Quoted 4 lines · Egbert Eich

SDVO LVDS are not clonable as the input mode gets adjusted by the LVDS encoder.

Imo cloning should simply die outright. Patch applied, thanks. -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch