Skip to contentSkip to conversation

Staging: sbe-2t3e3: fix coding style issues in netdev.c

PATCH New Pranav Ravichandran 1 participant 1 message Oct 15, 2012 Staging

lore
Share & tools
lore

Pranav Ravichandran

author
#0 lore raw

PATCH 1/1 Staging: sbe-2t3e3: fix coding style issues in netdev.c

This patch fixes a POINTER_LOCATION error(changed foo* bar to foo *bar) and an ASSIGN_IN_IF error(moved assignment out of if condition).

Signed-off-by Pranav Ravichandran <[email protected]>
---
 drivers/staging/sbe-2t3e3/netdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/sbe-2t3e3/netdev.c +3 -2
index 180c963..1f5088b 100644
@@ -57,7 +57,7 @@ static int t3e3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 	return 0;
 }
 
-static struct net_device_stats* t3e3_get_stats(struct net_device *dev)
+static struct net_device_stats *t3e3_get_stats(struct net_device *dev)
 {
 	struct net_device_stats *nstats = &dev->stats;
 	struct channel *sc = dev_to_priv(dev);

@@ -134,7 +134,8 @@ int setup_device(struct net_device *dev, struct channel *sc)
 	dev->tx_queue_len = 100;
 	hdlc->xmit = t3e3_if_start_xmit;
 	hdlc->attach = t3e3_attach;
-	if ((retval = register_hdlc_device(dev))) {
+	retval = register_hdlc_device(dev);
+	if (retval) {
 		dev_err(&sc->pdev->dev, "error registering HDLC device\n");
 		return retval;
 	}
Signature · 1 line
1.7.12.2