xen-netback: allow changing the MAC address of the interface
Subsystems (2)
PATCH 1/1 xen-netback: allow changing the MAC address of the interface
--- drivers/net/xen-netback/interface.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/xen-netback/interface.c +2 -0
@@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = { .ndo_stop = xenvif_close, .ndo_change_mtu = xenvif_change_mtu, .ndo_fix_features = xenvif_fix_features, + .ndo_set_mac_address = eth_mac_addr, + .ndo_validate_addr = eth_validate_addr, }; struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
Signature · 1 line
1.7.4.5
Quoted 3 lines · Matt Wilson
Reported-by Nikita Borzykh <[email protected]>Reported-by Paul Harvey <[email protected]>Suggested-by Ian Campbell <[email protected]>
I can't remember that but it seems reasonable:
But, can you remind us of the usecase? Perhaps in the commit message?
Lastly, netback patches should be sent to [email protected] as per MAINTAINERS in order to be applied.
Thanks,
Ian.
Quoted 18 lines
Signed-off-by Matt Wilson <[email protected]>--- drivers/net/xen-netback/interface.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/net/xen-netback/interface.c +2
-0@@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = { .ndo_stop = xenvif_close, .ndo_change_mtu = xenvif_change_mtu, .ndo_fix_features = xenvif_fix_features, + .ndo_set_mac_address = eth_mac_addr, + .ndo_validate_addr = eth_validate_addr, }; struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
Quoted 6 lines · Ian Campbell
Quoted 3 lines · Matt Wilson
Reported-by Nikita Borzykh <[email protected]>Reported-by Paul Harvey <[email protected]>Suggested-by Ian Campbell <[email protected]>I can't remember that but it seems reasonable:
http://lists.xen.org/archives/html/xen-devel/2011-01/msg01427.html
Quoted 3 lines
Acked-by Ian Campbell <[email protected]>But, can you remind us of the usecase? Perhaps in the commit message?
It could be useful for some ebtables configurations, I think.
Quoted 2 lines
Lastly, netback patches should be sent to [email protected] as per
MAINTAINERSin order to be applied.
Indeed. I wrongly assumed that Konrad would take care of bringing it into his tree and that it'd get pulled from there. I'll expand the commit message, add your Acked-by:, and send it on.
Matt
Quoted 19 lines
Quoted 18 lines
Signed-off-by Matt Wilson <[email protected]>--- drivers/net/xen-netback/interface.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/net/xen-netback/interface.c +2
-0@@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = { .ndo_stop = xenvif_close, .ndo_change_mtu = xenvif_change_mtu, .ndo_fix_features = xenvif_fix_features, + .ndo_set_mac_address = eth_mac_addr, + .ndo_validate_addr = eth_validate_addr, }; struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,