drm/i915: implement WaMbcDriverBootEnable on Haswell
Subsystems (2)
PATCH 1/1 drm/i915: implement WaMbcDriverBootEnable on Haswell
From: Paulo Zanoni <[email protected]>
Also document the WA name for the previous gens that implement it.
Signed-off-by Paulo Zanoni <[email protected]>
--- drivers/gpu/drm/i915/intel_pm.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +7 -0
@@ -3450,6 +3450,7 @@ static void gen6_init_clock_gating(struct drm_device *dev)ILK_DPARBUNIT_CLOCK_GATE_ENABLE | ILK_DPFDUNIT_CLOCK_GATE_ENABLE); +/* WaMbcDriverBootEnable */ I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) |GEN6_MBCTL_ENABLE_BOOT_FETCH );
@@ -3520,6 +3521,10 @@ static void haswell_init_clock_gating(struct drm_device *dev)I915_WRITE (CACHE_MODE_1 ,_MASKED_BIT_ENABLE (PIXEL_SUBSPAN_COLLECT_OPT_DISABLE )); +/* WaMbcDriverBootEnable */ +I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) | +GEN6_MBCTL_ENABLE_BOOT_FETCH ); +/* XXX: This is a workaround for early silicon revisions and should be * removed later. */
@@ -3595,6 +3600,7 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)intel_flush_display_plane (dev_priv, pipe); } +/* WaMbcDriverBootEnable */ I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) |GEN6_MBCTL_ENABLE_BOOT_FETCH );
@@ -3647,6 +3653,7 @@ static void valleyview_init_clock_gating(struct drm_device *dev)I915_READ (GEN7_SQ_CHICKEN_MBCUNIT_CONFIG ) | GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB); +/* WaMbcDriverBootEnable */ I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) |GEN6_MBCTL_ENABLE_BOOT_FETCH );
Signature · 1 line
1.7.11.4
Quoted 3 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
Also document the WA name for the previous gens that implement it.
Looks good based on the existing workarounds and specs; was unable to find any further details on the WA.
Reviewed-by Jani Nikula <[email protected]>
Quoted 51 lines
Signed-off-by Paulo Zanoni <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/gpu/drm/i915/intel_pm.c +7
-0@@ -3450,6 +3450,7 @@ static void gen6_init_clock_gating(struct drm_device *dev)ILK_DPARBUNIT_CLOCK_GATE_ENABLE | ILK_DPFDUNIT_CLOCK_GATE_ENABLE); +/* WaMbcDriverBootEnable */ I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) |GEN6_MBCTL_ENABLE_BOOT_FETCH );@@ -3520,6 +3521,10 @@ static void haswell_init_clock_gating(struct drm_device *dev)I915_WRITE (CACHE_MODE_1 ,_MASKED_BIT_ENABLE (PIXEL_SUBSPAN_COLLECT_OPT_DISABLE )); +/* WaMbcDriverBootEnable */ +I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) | +GEN6_MBCTL_ENABLE_BOOT_FETCH ); +/* XXX: This is a workaround for early silicon revisions and should be * removed later. */ @@ -3595,6 +3600,7 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)intel_flush_display_plane (dev_priv, pipe); } +/* WaMbcDriverBootEnable */ I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) |GEN6_MBCTL_ENABLE_BOOT_FETCH );@@ -3647,6 +3653,7 @@ static void valleyview_init_clock_gating(struct drm_device *dev)I915_READ (GEN7_SQ_CHICKEN_MBCUNIT_CONFIG ) | GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB); +/* WaMbcDriverBootEnable */ I915_WRITE (GEN6_MBCTL ,I915_READ (GEN6_MBCTL ) |GEN6_MBCTL_ENABLE_BOOT_FETCH );Signature · 6 lines
1.7.11.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx