Skip to contentSkip to conversation

mm: Add wait for page writeback in filemap_page_mkwrite()

PATCH New Jan Kara 1 participant 1 message Oct 31, 2012

Subsystems (3)
lore
Share & tools
lore

Jan Kara

author maintainer
#0 lore raw

PATCH 1/1 mm: Add wait for page writeback in filemap_page_mkwrite()

filemap_page_mkwrite() is the default function to handle writeable fault of a page. So make it wait for page writeback when stable pages during write are required by the underlying bdi.

---
 mm/filemap.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Darrick, can you add something like this patch to your series? After it
the only filesystems that don't get stable pages right are ncpfs, ceph, cifs, ubifs, and ocfs2. There are also other filesystems which will end up calling wait_on_page_writeback() unconditionally. I can fix these once the generic patches are stabilized.

mm/filemap.c +2 -0
index 83efee7..d4ed2c3 100644
@@ -1728,6 +1728,8 @@ int filemap_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
 	 * see the dirty page and writeprotect it again.
 	 */
 	set_page_dirty(page);
+	if (mapping_cap_stable_write(page->mapping))
+		wait_on_page_writeback(page);
 out:
 	sb_end_pagefault(inode->i_sb);
 	return ret;
Signature · 1 line
1.7.1