ASoC: mxs-pcm: Fix fifo size
Subsystems (3)
Fabio Estevam
reviewerPATCH v2 1/1 ASoC: mxs-pcm: Fix fifo size
From: Fabio Estevam <[email protected]>
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
---
Changes since v1:
- Fix info about FIFO size
sound/soc/mxs/mxs-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mxs/mxs-pcm.c +1 -1
@@ -60,7 +60,7 @@ static struct snd_pcm_hardware snd_mxs_hardware = { .periods_min = 1, .periods_max = 52, .buffer_bytes_max = 64 * 1024, - .fifo_size = 32, + .fifo_size = 4, };
Signature · 1 line
1.7.9.5
sound/soc/mxs/mxs-pcm.c static struct snd_pcm_hardware snd_mxs_hardware = { · line 63
Quoted 4 lines · Fabio Estevam
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
sound/soc/mxs/mxs-pcm.c +1
-1- .fifo_size = 32, + .fifo_size = 4,
fifo_size should be specified in bytes so the original code looks correct?
Quoted 9 lines · Mark Brown
sound/soc/mxs/mxs-pcm.c static struct snd_pcm_hardware snd_mxs_hardware = { · line 63
Quoted 4 lines · Fabio Estevam
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
sound/soc/mxs/mxs-pcm.c +1
-1- .fifo_size = 32, + .fifo_size = 4,
fifo_sizeshould be specified in bytes so the original code looks correct?
Then, probably it should be 16.
BTW, it seems this param is not used anymore:
http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/ch05s05.html
That may be the reason why i see some other platforms pcm code just set fifo_size to 0.
Regards
Dong Aisheng
Quoted 5 lines · Dong Aisheng
On 2 November 2012 23:06, Mark Brown
Quoted 3 lines · Fabio Estevam
Quoted 2 lines
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
Quoted 7 lines
Quoted 5 lines
sound/soc/mxs/mxs-pcm.c static struct snd_pcm_hardware snd_mxs_hardware = { · line 63
Quoted 2 lines
sound/soc/mxs/mxs-pcm.c +1
-1- .fifo_size = 32, + .fifo_size = 4,
fifo_sizeshould be specified in bytes so the original code looks correct?Then, probably it should be 16.
Yup.
Quoted 4 lines
BTW, it seems this param is not used anymore:
http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/ch05s05.html
That may be the reason why i see some other platforms pcm code just setfifo_sizeto 0.
Hrm, right - that'll be why nobody noticed. Guess it doesn't matter any more.