fat: warn when discard request fails other than EOPNOTSUPP

PATCH Superseded Namjae Jeon 1 participant 1 message Nov 3, 2012

Subsystems (2)

VFS VFAT/FAT/msdos filesystem

lore

Share & tools

lore

Namjae Jeon

author

2012-11-03 05:27 UTC #0 lore raw

PATCH 3/3 fat: warn when discard request fails other than EOPNOTSUPP

FAT also warn user then the discard request fails as ext4(http://patchwork.ozlabs.org/patch/192669/)

Signed-off-by Namjae Jeon <[email protected]>

Signed-off-by Amit Sahrawat <[email protected]>

---
 fs/fat/fatent.c |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

fs/fat/fatent.c +9 -6

index 260705c..fc1f407 100644
@@ -583,12 +583,15 @@ int fat_free_clusters(struct inode *inode, int cluster)
 			 */
 			if (cluster != fatent.entry + 1) {
 				int nr_clus = fatent.entry - first_cl + 1;
-
-				sb_issue_discard(sb,
-					fat_clus_to_blknr(sbi, first_cl),
-					nr_clus * sbi->sec_per_clus,
-					GFP_NOFS, 0);
-
+				sector_t sblk = fat_clus_to_blknr(sbi, first_cl);
+				sector_t nrblk = nr_clus * sbi->sec_per_clus;
+
+				err = sb_issue_discard(sb,
+						sblk, nrblk, GFP_NOFS, 0);
+				if (err && err != -EOPNOTSUPP)
+					fat_msg(sb, KERN_WARNING, "discard request for"
+							" block:%llu count:%llu failed"
+							" with %d", sblk, nrblk, err);
 				first_cl = cluster;
 			}
 		}

Signature · 1 line

1.7.9.5