Skip to contentSkip to conversation

pinctrl: Staticize pinconf_ops

PATCH In review Axel Lin 3 participants 3 messages Nov 7, 2012 – Nov 11, 2012

Subsystems (7)
Arm i.MX and Layerscape Tegra architecture support Arm/Microchip (AT91) SoC support Pin control +3 more subsystems
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 pinctrl: Staticize pinconf_ops

They are not referenced outside respective driver.

Signed-off-by Axel Lin <[email protected]>
Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Simon Arlott <[email protected]>
Cc John Crispin <[email protected]>
Cc Dong Aisheng <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Stephen Warren <[email protected]>
---
 drivers/pinctrl/pinctrl-at91.c    |    2 +-
 drivers/pinctrl/pinctrl-bcm2835.c |    2 +-
 drivers/pinctrl/pinctrl-falcon.c  |    2 +-
 drivers/pinctrl/pinctrl-imx.c     |    2 +-
 drivers/pinctrl/pinctrl-mxs.c     |    2 +-
 drivers/pinctrl/pinctrl-tegra.c   |    2 +-
 drivers/pinctrl/pinctrl-xway.c    |    2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
drivers/pinctrl/pinctrl-at91.c +1 -1
index b9e2cbd..8490a55 100644
@@ -665,7 +665,7 @@ static void at91_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
 {
 }
 
-struct pinconf_ops at91_pinconf_ops = {
+static struct pinconf_ops at91_pinconf_ops = {
 	.pin_config_get			= at91_pinconf_get,
 	.pin_config_set			= at91_pinconf_set,
 	.pin_config_dbg_show		= at91_pinconf_dbg_show,
drivers/pinctrl/pinctrl-bcm2835.c +1 -1
index 7e9be18..9a963ed 100644
@@ -916,7 +916,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-struct pinconf_ops bcm2835_pinconf_ops = {
+static struct pinconf_ops bcm2835_pinconf_ops = {
 	.pin_config_get = bcm2835_pinconf_get,
 	.pin_config_set = bcm2835_pinconf_set,
 };
drivers/pinctrl/pinctrl-falcon.c +1 -1
index ee73059..8ed20e8 100644
@@ -322,7 +322,7 @@ static void falcon_pinconf_group_dbg_show(struct pinctrl_dev *pctrldev,
 {
 }
 
-struct pinconf_ops falcon_pinconf_ops = {
+static struct pinconf_ops falcon_pinconf_ops = {
 	.pin_config_get			= falcon_pinconf_get,
 	.pin_config_set			= falcon_pinconf_set,
 	.pin_config_group_get		= falcon_pinconf_group_get,
drivers/pinctrl/pinctrl-imx.c +1 -1
index 63866d9..f3d2384 100644
@@ -397,7 +397,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
 	}
 }
 
-struct pinconf_ops imx_pinconf_ops = {
+static struct pinconf_ops imx_pinconf_ops = {
 	.pin_config_get = imx_pinconf_get,
 	.pin_config_set = imx_pinconf_set,
 	.pin_config_dbg_show = imx_pinconf_dbg_show,
drivers/pinctrl/pinctrl-mxs.c +1 -1
index 4ba4636..3e7d4d6 100644
@@ -319,7 +319,7 @@ static void mxs_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
 		seq_printf(s, "0x%lx", config);
 }
 
-struct pinconf_ops mxs_pinconf_ops = {
+static struct pinconf_ops mxs_pinconf_ops = {
 	.pin_config_get = mxs_pinconf_get,
 	.pin_config_set = mxs_pinconf_set,
 	.pin_config_group_get = mxs_pinconf_group_get,
drivers/pinctrl/pinctrl-tegra.c +1 -1
index 7da0b37..f7fe91e 100644
@@ -660,7 +660,7 @@ static void tegra_pinconf_config_dbg_show(struct pinctrl_dev *pctldev,
 }
 #endif
 
-struct pinconf_ops tegra_pinconf_ops = {
+static struct pinconf_ops tegra_pinconf_ops = {
 	.pin_config_get = tegra_pinconf_get,
 	.pin_config_set = tegra_pinconf_set,
 	.pin_config_group_get = tegra_pinconf_group_get,
drivers/pinctrl/pinctrl-xway.c +1 -1
index b9bcaec..ad90984 100644
@@ -522,7 +522,7 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-struct pinconf_ops xway_pinconf_ops = {
+static struct pinconf_ops xway_pinconf_ops = {
 	.pin_config_get	= xway_pinconf_get,
 	.pin_config_set	= xway_pinconf_set,
 };
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Axel Lin

They are not referenced outside respective driver.

Signed-off-by Axel Lin <[email protected]>
Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Simon Arlott <[email protected]>
Cc John Crispin <[email protected]>
Cc Dong Aisheng <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Stephen Warren <[email protected]>
Quoted 5 lines
---
 drivers/pinctrl/pinctrl-at91.c    |    2 +-
 drivers/pinctrl/pinctrl-bcm2835.c |    2 +-
 drivers/pinctrl/pinctrl-falcon.c  |    2 +-
 drivers/pinctrl/pinctrl-imx.c     |    2 +-

For imx,

Acked-by Dong Aisheng <[email protected]>

Regards
Dong Aisheng

Quoted 101 lines
 drivers/pinctrl/pinctrl-mxs.c     |    2 +-
 drivers/pinctrl/pinctrl-tegra.c   |    2 +-
 drivers/pinctrl/pinctrl-xway.c    |    2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
drivers/pinctrl/pinctrl-at91.c +1 -1
index b9e2cbd..8490a55 100644
@@ -665,7 +665,7 @@ static void at91_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
 {
 }
 
-struct pinconf_ops at91_pinconf_ops = {
+static struct pinconf_ops at91_pinconf_ops = {
        .pin_config_get                 = at91_pinconf_get,
        .pin_config_set                 = at91_pinconf_set,
        .pin_config_dbg_show            = at91_pinconf_dbg_show,
drivers/pinctrl/pinctrl-bcm2835.c +1 -1
index 7e9be18..9a963ed 100644
@@ -916,7 +916,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev,
        return 0;
 }
 
-struct pinconf_ops bcm2835_pinconf_ops = {
+static struct pinconf_ops bcm2835_pinconf_ops = {
        .pin_config_get = bcm2835_pinconf_get,
        .pin_config_set = bcm2835_pinconf_set,
 };
drivers/pinctrl/pinctrl-falcon.c +1 -1
index ee73059..8ed20e8 100644
@@ -322,7 +322,7 @@ static void falcon_pinconf_group_dbg_show(struct pinctrl_dev *pctrldev,
 {
 }
 
-struct pinconf_ops falcon_pinconf_ops = {
+static struct pinconf_ops falcon_pinconf_ops = {
        .pin_config_get                 = falcon_pinconf_get,
        .pin_config_set                 = falcon_pinconf_set,
        .pin_config_group_get           = falcon_pinconf_group_get,
drivers/pinctrl/pinctrl-imx.c +1 -1
index 63866d9..f3d2384 100644
@@ -397,7 +397,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
        }
 }
 
-struct pinconf_ops imx_pinconf_ops = {
+static struct pinconf_ops imx_pinconf_ops = {
        .pin_config_get = imx_pinconf_get,
        .pin_config_set = imx_pinconf_set,
        .pin_config_dbg_show = imx_pinconf_dbg_show,
drivers/pinctrl/pinctrl-mxs.c +1 -1
index 4ba4636..3e7d4d6 100644
@@ -319,7 +319,7 @@ static void mxs_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
                seq_printf(s, "0x%lx", config);
 }
 
-struct pinconf_ops mxs_pinconf_ops = {
+static struct pinconf_ops mxs_pinconf_ops = {
        .pin_config_get = mxs_pinconf_get,
        .pin_config_set = mxs_pinconf_set,
        .pin_config_group_get = mxs_pinconf_group_get,
drivers/pinctrl/pinctrl-tegra.c +1 -1
index 7da0b37..f7fe91e 100644
@@ -660,7 +660,7 @@ static void tegra_pinconf_config_dbg_show(struct pinctrl_dev *pctldev,
 }
 #endif
 
-struct pinconf_ops tegra_pinconf_ops = {
+static struct pinconf_ops tegra_pinconf_ops = {
        .pin_config_get = tegra_pinconf_get,
        .pin_config_set = tegra_pinconf_set,
        .pin_config_group_get = tegra_pinconf_group_get,
drivers/pinctrl/pinctrl-xway.c +1 -2
index b9bcaec..ad90984 100644
@@ -522,7 +522,7 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
        return 0;
 }
 
-struct pinconf_ops xway_pinconf_ops = {
+static struct pinconf_ops xway_pinconf_ops = {
        .pin_config_get = xway_pinconf_get,
        .pin_config_set = xway_pinconf_set,
 };
--

1.7.9.5

#2 lore raw
In reply to Axel Lin
Quoted 9 lines · Axel Lin

They are not referenced outside respective driver.

Signed-off-by Axel Lin <[email protected]>
Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Simon Arlott <[email protected]>
Cc John Crispin <[email protected]>
Cc Dong Aisheng <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Stephen Warren <[email protected]>

OK I had to merge down all my topic branches to the devel branch to apply this on top, but we are at -rc5 so it's about time!

Applied with Dong's ACK.

Yours,
Linus Walleij