ASoC: dapm: Use card_list during DAPM shutdown
PATCH 1/1 ASoC: dapm: Use card_list during DAPM shutdown
DAPM shutdown incorrectly uses "list" field of codec struct while iterating over probed components (codec_dev_list). "list" field refers to codecs registered in the system, "card_list" field is used for probed components.
--- sound/soc/soc-dapm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/soc-dapm.c +1 -1
@@ -3745,7 +3745,7 @@ void snd_soc_dapm_shutdown(struct snd_soc_card *card) {struct snd_soc_codec *codec; -list_for_each_entry (codec, &card->codec_dev_list, list) { +list_for_each_entry (codec, &card->codec_dev_list, card_list) {soc_dapm_shutdown_codec (&codec->dapm);if (codec->dapm.bias_level ==SND_SOC_BIAS_STANDBY ) snd_soc_dapm_set_bias_level(&codec->dapm,
Signature · 1 line
1.7.4.1
Mark Brown
AppliedQuoted 7 lines · Misael Lopez Cruz
DAPM shutdown incorrectly uses "list" field of codec struct while iterating over probed components (
codec_dev_list). "list" field refers to codecs registered in the system, "card_list" field is used for probed components.Signed-off-by Misael Lopez Cruz <[email protected]>Signed-off-by Liam Girdwood <[email protected]>
Applied, with Liam's signoff changed to an ack - please don't add signoffs for other people, the signoff means something fairly specific. Please see SubmittingPatches for details.
Quoted 6 lines · Mark Brown
Quoted 4 lines · Misael Lopez Cruz
DAPM shutdown incorrectly uses "list" field of codec struct while iterating over probed components (
codec_dev_list). "list" field refers to codecs registered in the system, "card_list" field is used for probed components.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Misael Lopez Cruz <[email protected]>Signed-off-by Liam Girdwood <[email protected]>Applied, with Liam's signoff changed to an ack - please don't add signoffs for other people, the signoff means something fairly specific. Please see SubmittingPatches for details.
Fwiw, We both worked on this hence the dual sign-off, I would have complained anyway if my ack/sob had been added by mistake.
Liam
Quoted 2 lines · Liam Girdwood
Fwiw, We both worked on this hence the dual sign-off, I would have complained anyway if my ack/sob had been added by mistake.
Ah, OK - normally for that the Signoffs will be the other way around (the person sending the mail last). I'll change it.