Skip to contentSkip to conversation

pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF

PATCH Superseded Axel Lin 3 participants 4 messages Nov 11, 2012 – Nov 12, 2012 Pin control

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF

Then we can remove "select PINMUX && PINCONF" from PINCTRL_TEGRA{20,30}. This simplifies the dependency.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/Kconfig |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/pinctrl/Kconfig +2 -4
index 6d5a50b..fc0f49a 100644
@@ -157,18 +157,16 @@ config PINCTRL_SIRF
 	select PINMUX
 
 config PINCTRL_TEGRA
+	select PINMUX
+	select PINCONF
 	bool
 
 config PINCTRL_TEGRA20
 	bool
-	select PINMUX
-	select PINCONF
 	select PINCTRL_TEGRA
 
 config PINCTRL_TEGRA30
 	bool
-	select PINMUX
-	select PINCONF
 	select PINCTRL_TEGRA
 
 config PINCTRL_U300
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/2 pinctrl: mxs: Make PINCTRL_MXS select PINMUX && PINCONF

Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}. This simplifies the dependency.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/Kconfig |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/pinctrl/Kconfig +2 -4
index fc0f49a..d5c9431 100644
@@ -99,18 +99,16 @@ config PINCTRL_MMP2
 	select PINCONF
 
 config PINCTRL_MXS
+	select PINMUX
+	select PINCONF
 	bool
 
 config PINCTRL_IMX23
 	bool
-	select PINMUX
-	select PINCONF
 	select PINCTRL_MXS
 
 config PINCTRL_IMX28
 	bool
-	select PINMUX
-	select PINCONF
 	select PINCTRL_MXS
 
 config PINCTRL_NOMADIK
Signature · 1 line
1.7.9.5
Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS select PINMUX && PINCONF

Quoted 13 lines · Axel Lin

Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}. This simplifies the dependency.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/Kconfig |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/pinctrl/Kconfig +0 -0
index fc0f49a..d5c9431 100644

drivers/pinctrl/Kconfig config PINCTRL_MMP2 · line 103

Quoted 5 lines
drivers/pinctrl/Kconfig +2 -0
@@ -99,18 +99,16 @@ config PINCTRL_MMP2
 	select PINCONF
 
 config PINCTRL_MXS
+	select PINMUX
+	select PINCONF

Better have them after 'bool' below, otherwise,

Acked-by Shawn Guo <[email protected]>
Quoted 20 lines
drivers/pinctrl/Kconfig +0 -4
 	bool
 
 config PINCTRL_IMX23
 	bool
-	select PINMUX
-	select PINCONF
 	select PINCTRL_MXS
 
 config PINCTRL_IMX28
 	bool
-	select PINMUX
-	select PINCONF
 	select PINCTRL_MXS
 
 config PINCTRL_NOMADIK
Signature · 1 line
1.7.9.5
Acked-by on v1 1/2
#3 lore raw
In reply to Axel Lin

drivers/pinctrl/Kconfig config PINCTRL_SIRF · line 162

Quoted 9 lines · Axel Lin

Then we can remove "select PINMUX && PINCONF" from PINCTRL_TEGRA{20,30}. This simplifies the dependency.

drivers/pinctrl/Kconfig +2 -0
 
 config PINCTRL_TEGRA
+	select PINMUX
+	select PINCONF
 	bool

With the same ordering comment as Shawn gave,

Acked-by Stephen Warren <[email protected]>