Skip to contentSkip to conversation

pinctrl: spear: Staticize non-exported symbols

PATCH In review Axel Lin 3 participants 3 messages Nov 11, 2012 – Nov 13, 2012

Subsystems (2)
Pin control Spear platform/clock/pinctrl support
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 pinctrl: spear: Staticize non-exported symbols

They are not referenced outside of this file, make them static.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/spear/pinctrl-spear.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/pinctrl/spear/pinctrl-spear.c +7 -5
index b1fd6ee..9a4dd4e 100644
@@ -121,9 +121,10 @@ static void spear_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
 	seq_printf(s, " " DRIVER_NAME);
 }
 
-int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
-				 struct device_node *np_config,
-				 struct pinctrl_map **map, unsigned *num_maps)
+static int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
+					struct device_node *np_config,
+					struct pinctrl_map **map,
+					unsigned *num_maps)
 {
 	struct spear_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
 	struct device_node *np;

@@ -168,8 +169,9 @@ int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
-		struct pinctrl_map *map, unsigned num_maps)
+static void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
+				      struct pinctrl_map *map,
+				      unsigned num_maps)
 {
 	kfree(map);
 }
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 27 lines · Axel Lin

They are not referenced outside of this file, make them static.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/spear/pinctrl-spear.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/pinctrl/spear/pinctrl-spear.c +4 -3
index b1fd6ee..9a4dd4e 100644
@@ -121,9 +121,10 @@ static void spear_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
        seq_printf(s, " " DRIVER_NAME);
 }
 
-int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
-                                struct device_node *np_config,
-                                struct pinctrl_map **map, unsigned *num_maps)
+static int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
+                                       struct device_node *np_config,
+                                       struct pinctrl_map **map,
+                                       unsigned *num_maps)
 {
        struct spear_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
        struct device_node *np;

@@ -168,8 +169,9 @@ int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
        return 0;

drivers/pinctrl/spear/pinctrl-spear.c int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, · line 177

Quoted 10 lines
drivers/pinctrl/spear/pinctrl-spear.c +3 -2
 }
 
-void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
-               struct pinctrl_map *map, unsigned num_maps)
+static void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
+                                     struct pinctrl_map *map,
+                                     unsigned num_maps)
 {
        kfree(map);
 }
Acked-by Viresh Kumar <[email protected]>