Skip to contentSkip to conversation

lockdep: be nice about building from userspace

PATCH In review Sasha Levin 3 participants 5 messages Nov 12, 2012 – Nov 27, 2013 Locking primitives

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lockdep: be nice about building from userspace

Lockdep is an awesome piece of code which detects locking issues which are relevant both to userspace and kernelspace. We can easily make lockdep work in userspace since there is really no kernel spacific magic going on in the code.

All we need is to wrap two functions which are used by lockdep and are very kernel specific.

Doing that will allow tools located in tools/ to easily utilize lockdep's code for their own use.

---
 kernel/lockdep.c | 4 ++++
 1 file changed, 4 insertions(+)
kernel/lockdep.c +4 -0
index 7981e5b..e898cfe 100644
@@ -584,6 +584,7 @@ static int very_verbose(struct lock_class *class)
 /*
  * Is this the address of a static object:
  */
+#ifdef __KERNEL__
 static int static_obj(void *obj)
 {
 	unsigned long start = (unsigned long) &_stext,
@@ -610,6 +611,7 @@ static int static_obj(void *obj)
 	 */
 	return is_module_address(addr) || is_module_percpu_address(addr);
 }
+#endif
 
 /*
  * To make lock name printouts unique, we calculate a unique
@@ -4109,6 +4111,7 @@ void debug_check_no_locks_held(struct task_struct *task)
 		print_held_locks_bug(task);
 }
 
+#ifdef __KERNEL__
 void debug_show_all_locks(void)
 {
 	struct task_struct *g, *p;
@@ -4166,6 +4169,7 @@ retry:
 		read_unlock(&tasklist_lock);
 }
 EXPORT_SYMBOL_GPL(debug_show_all_locks);
+#endif
 
 /*
  * Careful: only use this function if you are sure that
Signature · 1 line
1.8.0
#1 lore raw

Ping?

Quoted 53 lines · Sasha Levin

Lockdep is an awesome piece of code which detects locking issues which are relevant both to userspace and kernelspace. We can easily make lockdep work in userspace since there is really no kernel spacific magic going on in the code.

All we need is to wrap two functions which are used by lockdep and are very kernel specific.

Doing that will allow tools located in tools/ to easily utilize lockdep's code for their own use.

---
 kernel/lockdep.c | 4 ++++
 1 file changed, 4 insertions(+)
kernel/lockdep.c +4 -0
index 7981e5b..e898cfe 100644
@@ -584,6 +584,7 @@ static int very_verbose(struct lock_class *class)
 /*
  * Is this the address of a static object:
  */
+#ifdef __KERNEL__
 static int static_obj(void *obj)
 {
 	unsigned long start = (unsigned long) &_stext,
@@ -610,6 +611,7 @@ static int static_obj(void *obj)
 	 */
 	return is_module_address(addr) || is_module_percpu_address(addr);
 }
+#endif
 
 /*
  * To make lock name printouts unique, we calculate a unique
@@ -4109,6 +4111,7 @@ void debug_check_no_locks_held(struct task_struct *task)
 		print_held_locks_bug(task);
 }
 
+#ifdef __KERNEL__
 void debug_show_all_locks(void)
 {
 	struct task_struct *g, *p;
@@ -4166,6 +4169,7 @@ retry:
 		read_unlock(&tasklist_lock);
 }
 EXPORT_SYMBOL_GPL(debug_show_all_locks);
+#endif
 
 /*
  * Careful: only use this function if you are sure that
#2 lore raw

Ping?

Quoted 62 lines · Sasha Levin

Ping?

Quoted 46 lines · Sasha Levin

Lockdep is an awesome piece of code which detects locking issues which are relevant both to userspace and kernelspace. We can easily make lockdep work in userspace since there is really no kernel spacific magic going on in the code.

All we need is to wrap two functions which are used by lockdep and are very kernel specific.

Doing that will allow tools located in tools/ to easily utilize lockdep's code for their own use.

---
 kernel/lockdep.c | 4 ++++
 1 file changed, 4 insertions(+)
kernel/lockdep.c +3 -0
index 7981e5b..e898cfe 100644
@@ -584,6 +584,7 @@ static int very_verbose(struct lock_class *class)
 /*
  * Is this the address of a static object:
  */
+#ifdef __KERNEL__
 static int static_obj(void *obj)
 {
      unsigned long start = (unsigned long) &_stext,
@@ -610,6 +611,7 @@ static int static_obj(void *obj)
       */
      return is_module_address(addr) || is_module_percpu_address(addr);
 }
+#endif
 
 /*
  * To make lock name printouts unique, we calculate a unique
@@ -4109,6 +4111,7 @@ void debug_check_no_locks_held(struct task_struct *task)
              print_held_locks_bug(task);
 }
 
+#ifdef __KERNEL__
 void debug_show_all_locks(void)
 {
      struct task_struct *g, *p;

kernel/lockdep.c retry: · line 4175

Quoted 7 lines
kernel/lockdep.c +1 -0
@@ -4166,6 +4169,7 @@ retry:
              read_unlock(&tasklist_lock);
 }
 EXPORT_SYMBOL_GPL(debug_show_all_locks);
+#endif
 
 /*
  * Careful: only use this function if you are sure that

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw

[tip:core/locking] lockdep: Be nice about building from userspace

In reply to Sasha Levin
Commit-ID:  47dd80e801c32c114bcc6767ad190361c8b70172
Gitweb:     http://git.kernel.org/tip/47dd80e801c32c114bcc6767ad190361c8b70172
Author:     Sasha Levin <[email protected]>
AuthorDate: Mon, 12 Nov 2012 15:50:46 -0500
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 24 Jan 2013 17:54:50 +0100

lockdep: Be nice about building from userspace

Lockdep is an awesome piece of code which detects locking issues which are relevant both to userspace and kernelspace. We can easily make lockdep work in userspace since there is really no kernel spacific magic going on in the code.

All we need is to wrap two functions which are used by lockdep and are very kernel specific.

Doing that will allow tools located in tools/ to easily utilize lockdep's code for their own use.

---
 kernel/lockdep.c | 4 ++++
 1 file changed, 4 insertions(+)
kernel/lockdep.c +4 -0
index 5cf12e7..c783e80 100644
@@ -584,6 +584,7 @@ static int very_verbose(struct lock_class *class)
 /*
  * Is this the address of a static object:
  */
+#ifdef __KERNEL__
 static int static_obj(void *obj)
 {
 	unsigned long start = (unsigned long) &_stext,
@@ -610,6 +611,7 @@ static int static_obj(void *obj)
 	 */
 	return is_module_address(addr) || is_module_percpu_address(addr);
 }
+#endif
 
 /*
  * To make lock name printouts unique, we calculate a unique
@@ -4109,6 +4111,7 @@ void debug_check_no_locks_held(struct task_struct *task)
 		print_held_locks_bug(task);
 }
 
+#ifdef __KERNEL__
 void debug_show_all_locks(void)
 {
 	struct task_struct *g, *p;
@@ -4166,6 +4169,7 @@ retry:
 		read_unlock(&tasklist_lock);
 }
 EXPORT_SYMBOL_GPL(debug_show_all_locks);
+#endif
 
 /*
  * Careful: only use this function if you are sure that
#4 lore raw

[tip:core/locking] lockdep: Be nice about building from userspace

In reply to Sasha Levin
lockdep: Be nice about building from userspace
Commit-ID:  8dce7a9a6f4ca7163161a80a4603b66c88c5de8e
Gitweb:     http://git.kernel.org/tip/8dce7a9a6f4ca7163161a80a4603b66c88c5de8e
Author:     Sasha Levin <[email protected]>
AuthorDate: Thu, 13 Jun 2013 18:41:16 -0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 27 Nov 2013 11:55:20 +0100

lockdep: Be nice about building from userspace

Lockdep is an awesome piece of code which detects locking issues which are relevant both to userspace and kernelspace. We can easily make lockdep work in userspace since there is really no kernel spacific magic going on in the code.

All we need is to wrap two functions which are used by lockdep and are very kernel specific.

Doing that will allow tools located in tools/ to easily utilize lockdep's code for their own use.

---
 kernel/locking/lockdep.c | 4 ++++
 1 file changed, 4 insertions(+)
kernel/locking/lockdep.c +4 -0
index 576ba75..eb8a547 100644
@@ -590,6 +590,7 @@ static int very_verbose(struct lock_class *class)
 /*
  * Is this the address of a static object:
  */
+#ifdef __KERNEL__
 static int static_obj(void *obj)
 {
 	unsigned long start = (unsigned long) &_stext,
@@ -616,6 +617,7 @@ static int static_obj(void *obj)
 	 */
 	return is_module_address(addr) || is_module_percpu_address(addr);
 }
+#endif
 
 /*
  * To make lock name printouts unique, we calculate a unique
@@ -4115,6 +4117,7 @@ void debug_check_no_locks_held(void)
 }
 EXPORT_SYMBOL_GPL(debug_check_no_locks_held);
 
+#ifdef __KERNEL__
 void debug_show_all_locks(void)
 {
 	struct task_struct *g, *p;
@@ -4172,6 +4175,7 @@ retry:
 		read_unlock(&tasklist_lock);
 }
 EXPORT_SYMBOL_GPL(debug_show_all_locks);
+#endif
 
 /*
  * Careful: only use this function if you are sure that