Skip to contentSkip to conversation

regulator: tps80031: Implement list_voltage and set n_voltages = 1 for fixed regulators

PATCH Applied Axel Lin 3 participants 3 messages Nov 23, 2012 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: tps80031: Implement list_voltage and set n_voltages = 1 for fixed regulators

Implement list_voltage for fixed regulators, otherwise regulator_is_supported_voltage() returns 0.

---
 drivers/regulator/tps80031-regulator.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/regulator/tps80031-regulator.c +5 -1
index 6d5f203..50f89b0 100644
@@ -407,15 +407,18 @@ static struct regulator_ops tps80031_ldo_ops = {
 };
 
 static struct regulator_ops tps80031_vbus_sw_ops = {
+	.list_voltage	= regulator_list_voltage_linear,
 	.enable		= tps80031_vbus_enable,
 	.disable	= tps80031_vbus_disable,
 	.is_enabled	= tps80031_vbus_is_enabled,
 };
 
 static struct regulator_ops tps80031_vbus_hw_ops = {
+	.list_voltage	= regulator_list_voltage_linear,
 };
 
 static struct regulator_ops tps80031_ext_reg_ops = {
+	.list_voltage	= regulator_list_voltage_linear,
 	.enable		= tps80031_reg_enable,
 	.disable	= tps80031_reg_disable,
 	.is_enabled	= tps80031_reg_is_enabled,
@@ -477,7 +480,8 @@ static struct regulator_ops tps80031_ext_reg_ops = {
 	.desc = {						\
 		.name = "tps80031_"#_id,			\
 		.id = TPS80031_REGULATOR_##_id,			\
-		.n_voltages = 2,				\
+		.min_uV = max_mV * 1000,			\
+		.n_voltages = 1,				\
 		.ops = &_ops,					\
 		.type = REGULATOR_VOLTAGE,			\
 		.owner = THIS_MODULE,				\
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Axel Lin

Implement list_voltage for fixed regulators, otherwise regulator_is_supported_voltage() returns 0.

This rail is used for vbus only which is 5V or 0. I don't see any use for using this rail for other purpose. It just need enable/disable.

But this change does not hurt anything on my usage.

Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

Implement list_voltage for fixed regulators, otherwise regulator_is_supported_voltage() returns 0.

Applied, thanks.