Skip to contentSkip to conversation

ASoC: pcm: allow backend hardware to be freed in pause state

PATCH In review Patrick Lai 3 participants 4 messages Dec 6, 2012 – Dec 9, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: pcm: allow backend hardware to be freed in pause state

When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.

---
 sound/soc/soc-pcm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/soc-pcm.c +1 -1
index ef22d0b..d340644 100644
@@ -1240,7 +1240,7 @@ static int dpcm_be_dai_hw_free(struct snd_soc_pcm_runtime *fe, int stream)
 		if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_PARAMS) &&
 		    (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PREPARE) &&
 		    (be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_FREE) &&
+		    (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED) &&
 		    (be->dpcm[stream].state != SND_SOC_DPCM_STATE_STOP))
 			continue;
 
-- 

The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
1.7.8.3

Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Patrick Lai

When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.

#2 lore raw
In reply to Patrick Lai
Quoted 6 lines · Patrick Lai

When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.

I'm not entirely sure what this patch is generated against but it doesn't appear to apply to either -next or to v3.7-rc7 - can you check and regenerate please?

#3 lore raw
Quoted 8 lines · Mark Brown
Quoted 6 lines · Patrick Lai

When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.

Quoted 4 lines

I'm not entirely sure what this patch is generated against but it doesn't appear to apply to either -next or to v3.7-rc7 - can you check and regenerate please?

I generated this patch against tag v3.7-rc6. I just did a rebase against tag v3.7-rc7. I did not encounter merge error. I will regenerate patch again

Thanks
Patrick

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.