Skip to contentSkip to conversation

gpio: samsung: Add terminating entry for exynos_pinctrl_ids

PATCH Superseded Axel Lin 3 participants 3 messages Dec 10, 2012 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: samsung: Add terminating entry for exynos_pinctrl_ids

The of_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-samsung.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-samsung.c +1 -0
index 01f7fe9..9e251be 100644
@@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
 	static const struct of_device_id exynos_pinctrl_ids[] = {
 		{ .compatible = "samsung,pinctrl-exynos4210", },
 		{ .compatible = "samsung,pinctrl-exynos4x12", },
+		{ }
 	};
 	for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
 		if (pctrl_np && of_device_is_available(pctrl_np))
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 12 lines · Axel Lin

The of_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-samsung.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-samsung.c +0 -0
index 01f7fe9..9e251be 100644

drivers/gpio/gpio-samsung.c static __init int samsung_gpiolib_init(void) · line 3029

Quoted 4 lines
drivers/gpio/gpio-samsung.c +1 -0
@@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
        static const struct of_device_id exynos_pinctrl_ids[] = {
                { .compatible = "samsung,pinctrl-exynos4210", },
                { .compatible = "samsung,pinctrl-exynos4x12", },
+               { }

Wasn't somebody complaining that this was unnecessary recently?

Ohwell, I'll let the Samsung people comment first...

Yours,
Linus Walleij

Acked-by
#2 lore raw
Quoted 21 lines · Linus Walleij
Quoted 12 lines · Axel Lin

The of_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-samsung.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-samsung.c +0 -0
index 01f7fe9..9e251be 100644

drivers/gpio/gpio-samsung.c static __init int samsung_gpiolib_init(void) · line 3029

Quoted 4 lines
drivers/gpio/gpio-samsung.c +1 -0
@@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
        static const struct of_device_id exynos_pinctrl_ids[] = {
                { .compatible = "samsung,pinctrl-exynos4210", },
                { .compatible = "samsung,pinctrl-exynos4x12", },
+               { }

Wasn't somebody complaining that this was unnecessary recently?

Quoted 1 line

Ohwell, I'll let the Samsung people comment first...

And this doesn't apply on my gpio/next branch. I assume it applies somewhere else so I'll ignore for now. :-)

Acked-by Grant Likely <[email protected]>

g.